diff options
author | Khem Raj <raj.khem@gmail.com> | 2025-07-18 21:33:54 -0700 |
---|---|---|
committer | Khem Raj <raj.khem@gmail.com> | 2025-07-20 21:21:31 -0700 |
commit | ee88180afed0a68688ffb3a11631b76fc07841d7 (patch) | |
tree | 95c03a214d5d81e7d907b9b6e45f57041dea696e | |
parent | b8bdee746c4724282d3717b051159abd235ee420 (diff) | |
download | meta-openembedded-ee88180afed0a68688ffb3a11631b76fc07841d7.tar.gz |
libhugetlbfs: Do not add LDFLAGS to compiler
Add LDFLAGS in makefile for linking the helper libraries instead
when linking with LLD it ends up with errors
i686-yoe-linux-clang: warning: -Wl,-O1: 'linker' input unused [-Wunused-command-line-argument]
i686-yoe-linux-clang: warning: -Wl,--hash-style=gnu: 'linker' input unused [-Wunused-command-line-argument]
i686-yoe-linux-clang: warning: -Wl,--as-needed: 'linker' input unused [-Wunused-command-line-argument]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r-- | meta-oe/recipes-benchmark/libhugetlbfs/files/0014-tests-Add-ldflags-to-linker-commandline-for-libheaps.patch | 33 | ||||
-rw-r--r-- | meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_2.24.bb | 3 |
2 files changed, 34 insertions, 2 deletions
diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/files/0014-tests-Add-ldflags-to-linker-commandline-for-libheaps.patch b/meta-oe/recipes-benchmark/libhugetlbfs/files/0014-tests-Add-ldflags-to-linker-commandline-for-libheaps.patch new file mode 100644 index 0000000000..94a88647ea --- /dev/null +++ b/meta-oe/recipes-benchmark/libhugetlbfs/files/0014-tests-Add-ldflags-to-linker-commandline-for-libheaps.patch | |||
@@ -0,0 +1,33 @@ | |||
1 | From 834662425936ae222789f4823d10a1371b951ae1 Mon Sep 17 00:00:00 2001 | ||
2 | From: Khem Raj <raj.khem@gmail.com> | ||
3 | Date: Sun, 20 Jul 2025 14:19:59 -0700 | ||
4 | Subject: [PATCH] tests: Add ldflags to linker commandline for libheapshrink.so | ||
5 | |||
6 | This fixes build QA errors | ||
7 | ERROR: libhugetlbfs-1_2.24-r0 do_package_qa: QA Issue: File /usr/lib/libhugetlbfs/tests/obj64/libheapshrink.so in package libhugetlbfs-tests doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags] | ||
8 | |||
9 | Upstream-Status: Pending | ||
10 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
11 | --- | ||
12 | tests/Makefile.in | 4 ++-- | ||
13 | 1 file changed, 2 insertions(+), 2 deletions(-) | ||
14 | |||
15 | diff --git a/tests/Makefile.in b/tests/Makefile.in | ||
16 | index d33a228..042af8d 100644 | ||
17 | --- a/tests/Makefile.in | ||
18 | +++ b/tests/Makefile.in | ||
19 | @@ -140,12 +140,12 @@ obj64/%-pic.o: %.c | ||
20 | obj32/libheapshrink.so: obj32/heapshrink-helper-pic.o | ||
21 | @$(VECHO) LD32 "(shared)" $@ | ||
22 | @mkdir -p obj32 | ||
23 | - $(CC32) -Wl,-soname,$(notdir $@) -shared -o $@ $^ | ||
24 | + $(CC32) -Wl,-soname,$(notdir $@) -shared $(LDFLAGS) -o $@ $^ | ||
25 | |||
26 | obj64/libheapshrink.so: obj64/heapshrink-helper-pic.o | ||
27 | @$(VECHO) LD64 "(shared)" $@ | ||
28 | @mkdir -p obj64 | ||
29 | - $(CC64) -Wl,-soname,$(notdir $@) -shared -o $@ $^ | ||
30 | + $(CC64) -Wl,-soname,$(notdir $@) -shared $(LDFLAGS) -o $@ $^ | ||
31 | |||
32 | $(LIB_TESTS:%=obj32/%): %: %.o obj32/testutils.o obj32/libtestutils.o | ||
33 | @$(VECHO) LD32 "(lib test)" $@ | ||
diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_2.24.bb b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_2.24.bb index e688d6ede2..a43ddf0d53 100644 --- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_2.24.bb +++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_2.24.bb | |||
@@ -24,6 +24,7 @@ SRC_URI = " \ | |||
24 | file://0011-include-limits.h-for-PATH_MAX.patch \ | 24 | file://0011-include-limits.h-for-PATH_MAX.patch \ |
25 | file://0012-huge_page_setup_helper-use-python3-interpreter.patch \ | 25 | file://0012-huge_page_setup_helper-use-python3-interpreter.patch \ |
26 | file://0013-elflink.c-include-libgen.h-for-basename.patch \ | 26 | file://0013-elflink.c-include-libgen.h-for-basename.patch \ |
27 | file://0014-tests-Add-ldflags-to-linker-commandline-for-libheaps.patch \ | ||
27 | " | 28 | " |
28 | 29 | ||
29 | UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+(\.\d+)+)" | 30 | UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+(\.\d+)+)" |
@@ -42,8 +43,6 @@ CFLAGS += "-fexpensive-optimizations -frename-registers -fomit-frame-pointer -g0 | |||
42 | 43 | ||
43 | export HUGETLB_LDSCRIPT_PATH = "${S}/ldscripts" | 44 | export HUGETLB_LDSCRIPT_PATH = "${S}/ldscripts" |
44 | 45 | ||
45 | TARGET_CC_ARCH += "${LDFLAGS}" | ||
46 | |||
47 | LDFLAGS += "-B${S}" | 46 | LDFLAGS += "-B${S}" |
48 | 47 | ||
49 | inherit autotools-brokensep | 48 | inherit autotools-brokensep |