diff options
author | Mikko Gronoff <mikko.gronoff@qt.io> | 2017-04-20 08:30:19 +0300 |
---|---|---|
committer | Mikko Gronoff <mikko.gronoff@qt.io> | 2017-04-20 08:30:19 +0300 |
commit | 046dfb7d3689006927fa788fb935a26c02b81b31 (patch) | |
tree | 2268e0a4120287c7fdaf675b8108ea5ada13a02a | |
parent | 34b9d9fa2750bce915991828e707d8cf595da289 (diff) | |
parent | 5f837b47f5c3e462f24cd5abf58ff6ef1dd04932 (diff) | |
download | meta-qt5-046dfb7d3689006927fa788fb935a26c02b81b31.tar.gz |
Merge remote-tracking branch 'qtyocto/upstream/master' into 5.9
* upstream/master:
qttools: add ptest
qtwayland: fix initial window property values
qtdeclarative: fix memory leaks
Change-Id: Iaa0191e65a40a385b10c8b552fe791345aafdd6b
6 files changed, 99 insertions, 1 deletions
diff --git a/recipes-qt/qt5/qtdeclarative/0001-Fix-QQmlExpression-leaking-QQmlError-objects.patch b/recipes-qt/qt5/qtdeclarative/0001-Fix-QQmlExpression-leaking-QQmlError-objects.patch new file mode 100644 index 00000000..050a914e --- /dev/null +++ b/recipes-qt/qt5/qtdeclarative/0001-Fix-QQmlExpression-leaking-QQmlError-objects.patch | |||
@@ -0,0 +1,35 @@ | |||
1 | From f9dcbf008b430aadd464985b7a618eca8173d264 Mon Sep 17 00:00:00 2001 | ||
2 | From: Robert Griebl <robert.griebl@pelagicore.com> | ||
3 | Date: Thu, 23 Feb 2017 15:11:13 +0100 | ||
4 | Subject: [PATCH 1/3] Fix QQmlExpression leaking QQmlError objects | ||
5 | MIME-Version: 1.0 | ||
6 | Content-Type: text/plain; charset=UTF-8 | ||
7 | Content-Transfer-Encoding: 8bit | ||
8 | |||
9 | If the user doesn't clear any potential errors manually via clearError(), | ||
10 | then do it automatically in the destructor. Found with valgrind. | ||
11 | |||
12 | [ChangeLog][QtQml][QQmlExpression] Fixed memory leak | ||
13 | |||
14 | Change-Id: If5b1181850c7463c939a7ba536d74e7054c53d60 | ||
15 | Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> | ||
16 | Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com> | ||
17 | --- | ||
18 | src/qml/qml/qqmlexpression.cpp | 1 + | ||
19 | 1 file changed, 1 insertion(+) | ||
20 | |||
21 | diff --git a/src/qml/qml/qqmlexpression.cpp b/src/qml/qml/qqmlexpression.cpp | ||
22 | index 6afbd05..5cb3d4d 100644 | ||
23 | --- a/src/qml/qml/qqmlexpression.cpp | ||
24 | +++ b/src/qml/qml/qqmlexpression.cpp | ||
25 | @@ -200,6 +200,7 @@ QQmlExpression::QQmlExpression(QQmlContextData *ctxt, QObject *scope, | ||
26 | */ | ||
27 | QQmlExpression::~QQmlExpression() | ||
28 | { | ||
29 | + clearError(); | ||
30 | } | ||
31 | |||
32 | /*! | ||
33 | -- | ||
34 | 2.9.3 | ||
35 | |||
diff --git a/recipes-qt/qt5/qtdeclarative_git.bb b/recipes-qt/qt5/qtdeclarative_git.bb index 1ff6aa82..d4c711e0 100644 --- a/recipes-qt/qt5/qtdeclarative_git.bb +++ b/recipes-qt/qt5/qtdeclarative_git.bb | |||
@@ -14,6 +14,10 @@ LIC_FILES_CHKSUM = " \ | |||
14 | file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \ | 14 | file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \ |
15 | " | 15 | " |
16 | 16 | ||
17 | SRC_URI += " \ | ||
18 | file://0001-Fix-QQmlExpression-leaking-QQmlError-objects.patch \ | ||
19 | " | ||
20 | |||
17 | DEPENDS += "qtbase" | 21 | DEPENDS += "qtbase" |
18 | 22 | ||
19 | PACKAGECONFIG ??= "qtxmlpatterns" | 23 | PACKAGECONFIG ??= "qtxmlpatterns" |
diff --git a/recipes-qt/qt5/qttools/run-ptest b/recipes-qt/qt5/qttools/run-ptest new file mode 100644 index 00000000..5cd5e27e --- /dev/null +++ b/recipes-qt/qt5/qttools/run-ptest | |||
@@ -0,0 +1,4 @@ | |||
1 | #!/bin/sh | ||
2 | |||
3 | ./tst_qtdiag | ||
4 | ./tst_qtattributionsscanner | ||
diff --git a/recipes-qt/qt5/qttools_git.bb b/recipes-qt/qt5/qttools_git.bb index e8393096..51963027 100644 --- a/recipes-qt/qt5/qttools_git.bb +++ b/recipes-qt/qt5/qttools_git.bb | |||
@@ -14,9 +14,12 @@ LIC_FILES_CHKSUM = " \ | |||
14 | file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \ | 14 | file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \ |
15 | " | 15 | " |
16 | 16 | ||
17 | inherit ptest | ||
18 | |||
17 | DEPENDS += "qtbase qtdeclarative qtxmlpatterns" | 19 | DEPENDS += "qtbase qtdeclarative qtxmlpatterns" |
18 | 20 | ||
19 | SRC_URI += " \ | 21 | SRC_URI += " \ |
22 | file://run-ptest \ | ||
20 | file://0003-add-noqtwebkit-configuration.patch \ | 23 | file://0003-add-noqtwebkit-configuration.patch \ |
21 | file://0004-linguist-tools-cmake-allow-overriding-the-location-f.patch \ | 24 | file://0004-linguist-tools-cmake-allow-overriding-the-location-f.patch \ |
22 | " | 25 | " |
@@ -32,3 +35,17 @@ EXTRA_QMAKEVARS_PRE += "${@bb.utils.contains('PACKAGECONFIG', 'qtwebkit', '', 'C | |||
32 | SRCREV = "5c7b771829c52400ddd8f441972b37ce92da3b78" | 35 | SRCREV = "5c7b771829c52400ddd8f441972b37ce92da3b78" |
33 | 36 | ||
34 | BBCLASSEXTEND = "native nativesdk" | 37 | BBCLASSEXTEND = "native nativesdk" |
38 | |||
39 | do_compile_ptest() { | ||
40 | export PATH=${STAGING_DIR_NATIVE}/usr/include/qt5:$PATH | ||
41 | cd ${S}/tests | ||
42 | qmake -o Makefile tests.pro | ||
43 | oe_runmake | ||
44 | } | ||
45 | |||
46 | do_install_ptest() { | ||
47 | mkdir -p ${D}${PTEST_PATH} | ||
48 | t=${D}${PTEST_PATH} | ||
49 | cp ${S}/tests/auto/qtdiag/tst_tdiag $t | ||
50 | cp ${S}/tests/auto/qtattributionsscanner/tst_qtattributionsscanner $t | ||
51 | } | ||
diff --git a/recipes-qt/qt5/qtwayland/0002-Fix-initial-window-property-values-being-propagated.patch b/recipes-qt/qt5/qtwayland/0002-Fix-initial-window-property-values-being-propagated.patch new file mode 100644 index 00000000..29c9180c --- /dev/null +++ b/recipes-qt/qt5/qtwayland/0002-Fix-initial-window-property-values-being-propagated.patch | |||
@@ -0,0 +1,35 @@ | |||
1 | From 3d30fd8df9b55449844207295ad3d51cc8bb44b1 Mon Sep 17 00:00:00 2001 | ||
2 | From: Robert Griebl <robert.griebl@pelagicore.com> | ||
3 | Date: Thu, 15 Dec 2016 17:43:00 +0100 | ||
4 | Subject: [PATCH 2/2] Fix initial window property values being propagated | ||
5 | MIME-Version: 1.0 | ||
6 | Content-Type: text/plain; charset=UTF-8 | ||
7 | Content-Transfer-Encoding: 8bit | ||
8 | |||
9 | This was broken since the the shell-surface refactoring. | ||
10 | |||
11 | Change-Id: I130b7396e85c570a9d11d609af6b3016e3f706f0 | ||
12 | Reviewed-by: Dominik Holland <dominik.holland@pelagicore.com> | ||
13 | Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io> | ||
14 | Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com> | ||
15 | --- | ||
16 | src/client/qwaylandwindow.cpp | 3 +++ | ||
17 | 1 file changed, 3 insertions(+) | ||
18 | |||
19 | diff --git a/src/client/qwaylandwindow.cpp b/src/client/qwaylandwindow.cpp | ||
20 | index c8be9c1..b6f16f0 100644 | ||
21 | --- a/src/client/qwaylandwindow.cpp | ||
22 | +++ b/src/client/qwaylandwindow.cpp | ||
23 | @@ -176,6 +176,9 @@ void QWaylandWindow::initWindow() | ||
24 | mShellSurface->setAppId(appId); | ||
25 | } | ||
26 | } | ||
27 | + // the user may have already set some window properties, so make sure to send them out | ||
28 | + for (auto it = m_properties.cbegin(); it != m_properties.cend(); ++it) | ||
29 | + mShellSurface->sendProperty(it.key(), it.value()); | ||
30 | } | ||
31 | |||
32 | // Enable high-dpi rendering. Scale() returns the screen scale factor and will | ||
33 | -- | ||
34 | 2.9.3 | ||
35 | |||
diff --git a/recipes-qt/qt5/qtwayland_git.bb b/recipes-qt/qt5/qtwayland_git.bb index 29b1b4a4..2ed11ec4 100644 --- a/recipes-qt/qt5/qtwayland_git.bb +++ b/recipes-qt/qt5/qtwayland_git.bb | |||
@@ -44,6 +44,9 @@ EXTRA_QMAKEVARS_CONFIGURE += "${PACKAGECONFIG_CONFARGS}" | |||
44 | SRCREV = "c26f8dbd5c5ff15167e90db529845091705cbe46" | 44 | SRCREV = "c26f8dbd5c5ff15167e90db529845091705cbe46" |
45 | 45 | ||
46 | # From https://bugreports.qt.io/browse/QTBUG-57767 | 46 | # From https://bugreports.qt.io/browse/QTBUG-57767 |
47 | SRC_URI += "file://0001-fix-build-without-xkbcommon-evdev.patch" | 47 | SRC_URI += " \ |
48 | file://0001-fix-build-without-xkbcommon-evdev.patch \ | ||
49 | file://0002-Fix-initial-window-property-values-being-propagated.patch \ | ||
50 | " | ||
48 | 51 | ||
49 | BBCLASSEXTEND =+ "native nativesdk" | 52 | BBCLASSEXTEND =+ "native nativesdk" |