summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuli Piippo <samuli.piippo@qt.io>2018-10-30 16:34:51 +0200
committerSamuli Piippo <samuli.piippo@qt.io>2018-11-15 06:36:46 +0000
commit4064b3b6ea53fb1ee1f9f96b06c6abe120b830f4 (patch)
tree48f0052e322a871929ba216846b06fca359802f4
parente863df2be9e966811a80f0e3717af911478fd748 (diff)
downloadmeta-qt5-4064b3b6ea53fb1ee1f9f96b06c6abe120b830f4.tar.gz
qtdeclarative: fix inconsistent QML_COMPILE_HASH value
qtdeclarative and qtdeclarative-native may end up with different values for QML_COMPILE_HASH, which prevents running QML application when qtquickcompiler has been used. Change-Id: I29f42915629ca5da7507fdd20cfe0c64f445df9f Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
-rw-r--r--recipes-qt/qt5/qtdeclarative/0001-Always-use-commit-sha1-for-QML_COMPILE_HASH.patch31
-rw-r--r--recipes-qt/qt5/qtdeclarative_git.bb2
2 files changed, 33 insertions, 0 deletions
diff --git a/recipes-qt/qt5/qtdeclarative/0001-Always-use-commit-sha1-for-QML_COMPILE_HASH.patch b/recipes-qt/qt5/qtdeclarative/0001-Always-use-commit-sha1-for-QML_COMPILE_HASH.patch
new file mode 100644
index 00000000..a734f8a2
--- /dev/null
+++ b/recipes-qt/qt5/qtdeclarative/0001-Always-use-commit-sha1-for-QML_COMPILE_HASH.patch
@@ -0,0 +1,31 @@
1From 260e165993fe15a1668cfd36caee18a95b2d2f59 Mon Sep 17 00:00:00 2001
2From: Samuli Piippo <samuli.piippo@qt.io>
3Date: Mon, 2 Jul 2018 13:32:44 +0300
4Subject: [PATCH] Always use commit sha1 for QML_COMPILE_HASH
5
6git describe can produce different strings for the same sha1, depending
7on the version of git (length of short hash) and whether release tag was
8in place when build was done (v5.11.1-0- vs. v5.11.0-66-).
9
10Instead use rev-parse to get the unambiguous commit sha1 which is also
11what is used from the .tag file.
12
13Change-Id: If378f03eb764e2d858bda5b662106aa4402d6559
14Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
15---
16 src/qml/qml.pro | 2 +-
17 1 file changed, 1 insertion(+), 1 deletion(-)
18
19diff --git a/src/qml/qml.pro b/src/qml/qml.pro
20index 940ebb325..a76a87b15 100644
21--- a/src/qml/qml.pro
22+++ b/src/qml/qml.pro
23@@ -31,7 +31,7 @@ DEFINES += QT_NO_FOREACH
24 !equals(tag, "$${LITERAL_DOLLAR}Format:%H$${LITERAL_DOLLAR}") {
25 QML_COMPILE_HASH = $$tag
26 } else:exists($$PWD/../../.git) {
27- commit = $$system(git describe --tags --always --long --dirty)
28+ commit = $$system(git rev-parse HEAD)
29 QML_COMPILE_HASH = $$commit
30 }
31 compile_hash_contents = \
diff --git a/recipes-qt/qt5/qtdeclarative_git.bb b/recipes-qt/qt5/qtdeclarative_git.bb
index 39095e59..3cb0a602 100644
--- a/recipes-qt/qt5/qtdeclarative_git.bb
+++ b/recipes-qt/qt5/qtdeclarative_git.bb
@@ -12,6 +12,8 @@ LIC_FILES_CHKSUM = " \
12 file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \ 12 file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \
13" 13"
14 14
15SRC_URI += "file://0001-Always-use-commit-sha1-for-QML_COMPILE_HASH.patch"
16
15DEPENDS += "qtbase" 17DEPENDS += "qtbase"
16 18
17PACKAGECONFIG ??= "qtxmlpatterns qml-debug qml-network ${@bb.utils.contains('DISTRO_FEATURES', 'qt5-static', 'static', '', d)}" 19PACKAGECONFIG ??= "qtxmlpatterns qml-debug qml-network ${@bb.utils.contains('DISTRO_FEATURES', 'qt5-static', 'static', '', d)}"