summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuli Piippo <samuli.piippo@qt.io>2019-01-08 14:51:33 +0200
committerSamuli Piippo <samuli.piippo@qt.io>2019-01-10 06:05:48 +0000
commit9c6ce8100223675bf970b647f96e89e5ecceaaa6 (patch)
treed441343ab6d181f805dd0c4d69a505be4e00ea85
parentf7d2387ba0d80c26ae4febec5c37b05e8df7a32b (diff)
downloadmeta-qt5-9c6ce8100223675bf970b647f96e89e5ecceaaa6.tar.gz
qt5: cleanup mkspecs
QMAKE_COMPILER is not meant to be the actual compiler, but a compiler type (gcc, clang, mingw). For both mkspecs it's already set in the common includes. Remove wayland and debug settings from the clang mkspec as they are already removed from the gcc mkspec. Change-Id: I59ebc64007ebb828d70cf769121bc2d64886d1c0 Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
-rw-r--r--classes/qmake5_base.bbclass2
-rw-r--r--recipes-qt/qt5/qtbase/0001-Add-linux-oe-g-platform.patch23
-rw-r--r--recipes-qt/qt5/qtbase/0009-Add-OE-specific-specs-for-clang-compiler.patch14
3 files changed, 16 insertions, 23 deletions
diff --git a/classes/qmake5_base.bbclass b/classes/qmake5_base.bbclass
index b3a4826a..48da05e8 100644
--- a/classes/qmake5_base.bbclass
+++ b/classes/qmake5_base.bbclass
@@ -20,7 +20,6 @@ SSTATE_SCAN_FILES += "*.pri *.prl *.prf"
20# then OE_QMAKE_CFLAGS are exported and used correctly, but then whole CFLAGS is overwritten from env (and -fPIC lost and build fails) 20# then OE_QMAKE_CFLAGS are exported and used correctly, but then whole CFLAGS is overwritten from env (and -fPIC lost and build fails)
21EXTRA_OEMAKE = " \ 21EXTRA_OEMAKE = " \
22 MAKEFLAGS='${PARALLEL_MAKE}' \ 22 MAKEFLAGS='${PARALLEL_MAKE}' \
23 OE_QMAKE_COMPILER='${OE_QMAKE_COMPILER}' \
24 OE_QMAKE_CC='${OE_QMAKE_CC}' \ 23 OE_QMAKE_CC='${OE_QMAKE_CC}' \
25 OE_QMAKE_CXX='${OE_QMAKE_CXX}' \ 24 OE_QMAKE_CXX='${OE_QMAKE_CXX}' \
26 OE_QMAKE_CFLAGS='${OE_QMAKE_CFLAGS}' \ 25 OE_QMAKE_CFLAGS='${OE_QMAKE_CFLAGS}' \
@@ -33,7 +32,6 @@ EXTRA_OEMAKE = " \
33" 32"
34 33
35OE_QMAKE_QMAKE = "${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qmake" 34OE_QMAKE_QMAKE = "${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}/qmake"
36export OE_QMAKE_COMPILER = "${CC}"
37export OE_QMAKE_CC = "${CC}" 35export OE_QMAKE_CC = "${CC}"
38export OE_QMAKE_CFLAGS = "${CFLAGS}" 36export OE_QMAKE_CFLAGS = "${CFLAGS}"
39export OE_QMAKE_CXX = "${CXX}" 37export OE_QMAKE_CXX = "${CXX}"
diff --git a/recipes-qt/qt5/qtbase/0001-Add-linux-oe-g-platform.patch b/recipes-qt/qt5/qtbase/0001-Add-linux-oe-g-platform.patch
index c22eb2e1..02c89c6a 100644
--- a/recipes-qt/qt5/qtbase/0001-Add-linux-oe-g-platform.patch
+++ b/recipes-qt/qt5/qtbase/0001-Add-linux-oe-g-platform.patch
@@ -1,4 +1,4 @@
1From a6f4987a281315dacc7b8b55928b9c0793cd0813 Mon Sep 17 00:00:00 2001 1From f00d8dcdccde47a969f8c670baba1b196076bac0 Mon Sep 17 00:00:00 2001
2From: Martin Jansa <Martin.Jansa@gmail.com> 2From: Martin Jansa <Martin.Jansa@gmail.com>
3Date: Mon, 15 Apr 2013 04:29:32 +0200 3Date: Mon, 15 Apr 2013 04:29:32 +0200
4Subject: [PATCH] Add linux-oe-g++ platform 4Subject: [PATCH] Add linux-oe-g++ platform
@@ -24,14 +24,14 @@ Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
24 mkspecs/features/configure.prf | 4 +-- 24 mkspecs/features/configure.prf | 4 +--
25 mkspecs/features/qt.prf | 6 ++--- 25 mkspecs/features/qt.prf | 6 ++---
26 mkspecs/features/qt_functions.prf | 2 +- 26 mkspecs/features/qt_functions.prf | 2 +-
27 mkspecs/linux-oe-g++/qmake.conf | 40 ++++++++++++++++++++++++++++ 27 mkspecs/linux-oe-g++/qmake.conf | 39 ++++++++++++++++++++++++++++
28 mkspecs/linux-oe-g++/qplatformdefs.h | 1 + 28 mkspecs/linux-oe-g++/qplatformdefs.h | 1 +
29 6 files changed, 48 insertions(+), 7 deletions(-) 29 6 files changed, 47 insertions(+), 7 deletions(-)
30 create mode 100644 mkspecs/linux-oe-g++/qmake.conf 30 create mode 100644 mkspecs/linux-oe-g++/qmake.conf
31 create mode 100644 mkspecs/linux-oe-g++/qplatformdefs.h 31 create mode 100644 mkspecs/linux-oe-g++/qplatformdefs.h
32 32
33diff --git a/configure b/configure 33diff --git a/configure b/configure
34index 2830a1b1897..6445dc2d5a0 100755 34index ef7bad1bfc..dcca0f9135 100755
35--- a/configure 35--- a/configure
36+++ b/configure 36+++ b/configure
37@@ -712,7 +712,7 @@ fi 37@@ -712,7 +712,7 @@ fi
@@ -44,7 +44,7 @@ index 2830a1b1897..6445dc2d5a0 100755
44 44
45 # build qmake 45 # build qmake
46diff --git a/mkspecs/features/configure.prf b/mkspecs/features/configure.prf 46diff --git a/mkspecs/features/configure.prf b/mkspecs/features/configure.prf
47index 934a18a9249..0f5b1b63334 100644 47index 934a18a924..0f5b1b6333 100644
48--- a/mkspecs/features/configure.prf 48--- a/mkspecs/features/configure.prf
49+++ b/mkspecs/features/configure.prf 49+++ b/mkspecs/features/configure.prf
50@@ -46,14 +46,14 @@ defineTest(qtCompileTest) { 50@@ -46,14 +46,14 @@ defineTest(qtCompileTest) {
@@ -65,7 +65,7 @@ index 934a18a9249..0f5b1b63334 100644
65 msg = "test $$1 succeeded" 65 msg = "test $$1 succeeded"
66 write_file($$QMAKE_CONFIG_LOG, msg, append) 66 write_file($$QMAKE_CONFIG_LOG, msg, append)
67diff --git a/mkspecs/features/qt.prf b/mkspecs/features/qt.prf 67diff --git a/mkspecs/features/qt.prf b/mkspecs/features/qt.prf
68index b57afcf72d..afa1c39b3e 100644 68index 5da82fdb5b..3f56aac97a 100644
69--- a/mkspecs/features/qt.prf 69--- a/mkspecs/features/qt.prf
70+++ b/mkspecs/features/qt.prf 70+++ b/mkspecs/features/qt.prf
71@@ -147,7 +147,7 @@ import_plugins:qtConfig(static) { 71@@ -147,7 +147,7 @@ import_plugins:qtConfig(static) {
@@ -77,7 +77,7 @@ index b57afcf72d..afa1c39b3e 100644
77 LIBS += -L$$plug_path/$$plug_type 77 LIBS += -L$$plug_path/$$plug_type
78 } 78 }
79 LIBS += -l$${plug}$$qtPlatformTargetSuffix() 79 LIBS += -l$${plug}$$qtPlatformTargetSuffix()
80@@ -298,8 +298,8 @@ for(ever) { 80@@ -285,8 +285,8 @@ for(ever) {
81 # static builds: link qml import plugins into the target. 81 # static builds: link qml import plugins into the target.
82 contains(all_qt_module_deps, qml): \ 82 contains(all_qt_module_deps, qml): \
83 qtConfig(static):import_plugins:!host_build:!no_import_scan { 83 qtConfig(static):import_plugins:!host_build:!no_import_scan {
@@ -89,7 +89,7 @@ index b57afcf72d..afa1c39b3e 100644
89 # run qmlimportscanner 89 # run qmlimportscanner
90 qtPrepareTool(QMLIMPORTSCANNER, qmlimportscanner, , system) 90 qtPrepareTool(QMLIMPORTSCANNER, qmlimportscanner, , system)
91diff --git a/mkspecs/features/qt_functions.prf b/mkspecs/features/qt_functions.prf 91diff --git a/mkspecs/features/qt_functions.prf b/mkspecs/features/qt_functions.prf
92index 1903e509c8e..c093dd4592d 100644 92index 1903e509c8..c093dd4592 100644
93--- a/mkspecs/features/qt_functions.prf 93--- a/mkspecs/features/qt_functions.prf
94+++ b/mkspecs/features/qt_functions.prf 94+++ b/mkspecs/features/qt_functions.prf
95@@ -69,7 +69,7 @@ defineTest(qtHaveModule) { 95@@ -69,7 +69,7 @@ defineTest(qtHaveModule) {
@@ -103,10 +103,10 @@ index 1903e509c8e..c093dd4592d 100644
103 cmd = perl -w $$system_path($${cmd}.pl) 103 cmd = perl -w $$system_path($${cmd}.pl)
104diff --git a/mkspecs/linux-oe-g++/qmake.conf b/mkspecs/linux-oe-g++/qmake.conf 104diff --git a/mkspecs/linux-oe-g++/qmake.conf b/mkspecs/linux-oe-g++/qmake.conf
105new file mode 100644 105new file mode 100644
106index 0000000000..f34a66599a 106index 0000000000..c202c47fa1
107--- /dev/null 107--- /dev/null
108+++ b/mkspecs/linux-oe-g++/qmake.conf 108+++ b/mkspecs/linux-oe-g++/qmake.conf
109@@ -0,0 +1,40 @@ 109@@ -0,0 +1,39 @@
110+# 110+#
111+# qmake configuration for linux-g++ with modifications for building with OpenEmbedded 111+# qmake configuration for linux-g++ with modifications for building with OpenEmbedded
112+# 112+#
@@ -131,7 +131,6 @@ index 0000000000..f34a66599a
131+include(../common/g++-unix.conf) 131+include(../common/g++-unix.conf)
132+ 132+
133+# tc settings from g++-base.conf 133+# tc settings from g++-base.conf
134+QMAKE_COMPILER = $$(OE_QMAKE_COMPILER) gcc
135+QMAKE_CC = $$(OE_QMAKE_CC) 134+QMAKE_CC = $$(OE_QMAKE_CC)
136+QMAKE_CXX = $$(OE_QMAKE_CXX) 135+QMAKE_CXX = $$(OE_QMAKE_CXX)
137+ 136+
@@ -149,7 +148,7 @@ index 0000000000..f34a66599a
149+load(qt_config) 148+load(qt_config)
150diff --git a/mkspecs/linux-oe-g++/qplatformdefs.h b/mkspecs/linux-oe-g++/qplatformdefs.h 149diff --git a/mkspecs/linux-oe-g++/qplatformdefs.h b/mkspecs/linux-oe-g++/qplatformdefs.h
151new file mode 100644 150new file mode 100644
152index 00000000000..5d22fb41013 151index 0000000000..5d22fb4101
153--- /dev/null 152--- /dev/null
154+++ b/mkspecs/linux-oe-g++/qplatformdefs.h 153+++ b/mkspecs/linux-oe-g++/qplatformdefs.h
155@@ -0,0 +1 @@ 154@@ -0,0 +1 @@
diff --git a/recipes-qt/qt5/qtbase/0009-Add-OE-specific-specs-for-clang-compiler.patch b/recipes-qt/qt5/qtbase/0009-Add-OE-specific-specs-for-clang-compiler.patch
index ca74f0f7..fe5746e2 100644
--- a/recipes-qt/qt5/qtbase/0009-Add-OE-specific-specs-for-clang-compiler.patch
+++ b/recipes-qt/qt5/qtbase/0009-Add-OE-specific-specs-for-clang-compiler.patch
@@ -1,22 +1,22 @@
1From 51bc56305205a154db22c1373eb19d835ba2c64e Mon Sep 17 00:00:00 2001 1From 4486a9740b07aa7902f638efe23a51ee619f9600 Mon Sep 17 00:00:00 2001
2From: Khem Raj <raj.khem@gmail.com> 2From: Khem Raj <raj.khem@gmail.com>
3Date: Sun, 3 Sep 2017 09:11:44 -0700 3Date: Sun, 3 Sep 2017 09:11:44 -0700
4Subject: [PATCH] Add OE specific specs for clang compiler 4Subject: [PATCH] Add OE specific specs for clang compiler
5 5
6Signed-off-by: Khem Raj <raj.khem@gmail.com> 6Signed-off-by: Khem Raj <raj.khem@gmail.com>
7--- 7---
8 mkspecs/linux-oe-clang/qmake.conf | 43 ++++++++++++++++++++++++++ 8 mkspecs/linux-oe-clang/qmake.conf | 39 ++++++++++++++++++++++++++
9 mkspecs/linux-oe-clang/qplatformdefs.h | 1 + 9 mkspecs/linux-oe-clang/qplatformdefs.h | 1 +
10 2 files changed, 44 insertions(+) 10 2 files changed, 40 insertions(+)
11 create mode 100644 mkspecs/linux-oe-clang/qmake.conf 11 create mode 100644 mkspecs/linux-oe-clang/qmake.conf
12 create mode 100644 mkspecs/linux-oe-clang/qplatformdefs.h 12 create mode 100644 mkspecs/linux-oe-clang/qplatformdefs.h
13 13
14diff --git a/mkspecs/linux-oe-clang/qmake.conf b/mkspecs/linux-oe-clang/qmake.conf 14diff --git a/mkspecs/linux-oe-clang/qmake.conf b/mkspecs/linux-oe-clang/qmake.conf
15new file mode 100644 15new file mode 100644
16index 0000000000..b0a5630fdd 16index 0000000000..db02ab5215
17--- /dev/null 17--- /dev/null
18+++ b/mkspecs/linux-oe-clang/qmake.conf 18+++ b/mkspecs/linux-oe-clang/qmake.conf
19@@ -0,0 +1,43 @@ 19@@ -0,0 +1,39 @@
20+# 20+#
21+# qmake configuration for linux-g++ with modifications for building with OpenEmbedded 21+# qmake configuration for linux-g++ with modifications for building with OpenEmbedded
22+# 22+#
@@ -30,7 +30,6 @@ index 0000000000..b0a5630fdd
30+# QMAKE_<TOOL> (moc, uic, rcc) are gone, overwrite only ar and strip 30+# QMAKE_<TOOL> (moc, uic, rcc) are gone, overwrite only ar and strip
31+QMAKE_AR = $$(OE_QMAKE_AR) cqs 31+QMAKE_AR = $$(OE_QMAKE_AR) cqs
32+QMAKE_STRIP = $$(OE_QMAKE_STRIP) 32+QMAKE_STRIP = $$(OE_QMAKE_STRIP)
33+QMAKE_WAYLAND_SCANNER = $$(OE_QMAKE_WAYLAND_SCANNER)
34+ 33+
35+include(../common/gcc-base-unix.conf) 34+include(../common/gcc-base-unix.conf)
36+ 35+
@@ -42,12 +41,9 @@ index 0000000000..b0a5630fdd
42+include(../common/clang.conf) 41+include(../common/clang.conf)
43+ 42+
44+# tc settings from g++-base.conf 43+# tc settings from g++-base.conf
45+QMAKE_COMPILER = $$(OE_QMAKE_COMPILER) clang
46+QMAKE_CC = $$(OE_QMAKE_CC) 44+QMAKE_CC = $$(OE_QMAKE_CC)
47+QMAKE_CXX = $$(OE_QMAKE_CXX) 45+QMAKE_CXX = $$(OE_QMAKE_CXX)
48+ 46+
49+QMAKE_CFLAGS_RELEASE_WITH_DEBUGINFO += $$(OE_QMAKE_CFLAGS)
50+
51+QMAKE_LINK = $$(OE_QMAKE_LINK) 47+QMAKE_LINK = $$(OE_QMAKE_LINK)
52+QMAKE_LINK_SHLIB = $$(OE_QMAKE_LINK) 48+QMAKE_LINK_SHLIB = $$(OE_QMAKE_LINK)
53+QMAKE_LINK_C = $$(OE_QMAKE_LINK) 49+QMAKE_LINK_C = $$(OE_QMAKE_LINK)