diff options
author | Bruce Ashfield <bruce.ashfield@gmail.com> | 2022-09-12 15:34:59 -0400 |
---|---|---|
committer | Bruce Ashfield <bruce.ashfield@gmail.com> | 2022-09-12 15:46:00 -0400 |
commit | 9ef3fa52d049d5c9ffebcbcbd9d2dd7598fd6685 (patch) | |
tree | cc0449d5e8478ce2246c18ac4fe601cbc38c727f /recipes-containers/containerd/containerd-opencontainers/0001-Add-build-option-GODEBUG-1.patch | |
parent | 08a59b4d934f601307d0a3cb9ab3a835904baecb (diff) | |
download | meta-virtualization-9ef3fa52d049d5c9ffebcbcbd9d2dd7598fd6685.tar.gz |
containerd: improve reproducibility
We get the following QA warning on build:
WARNING: containerd-opencontainers-v1.6.8+gitAUTOINC+579a6380ec-r0 do_package_qa: QA Issue: File /usr/bin/containerd-shim-runc-v2 in package containerd-opencontainers contains reference to TMPDIR
File /usr/bin/containerd-ctr in package containerd-opencontainers contains reference to TMPDIR
File /usr/bin/containerd-shim-runc-v1 in package containerd-opencontainers contains reference to TMPDIR
File /usr/bin/containerd in package containerd-opencontainers contains reference to TMPDIR
File /usr/bin/containerd-shim in package containerd-opencontainers contains reference to TMPDIR [buildpaths]
This is the first step in fixing the QA warning, by dropping our
debug patch, passing -trimpath and not defining GO_DEBUG.
This leaves a final reference similar to:
path _/opt/poky/build/tmp/work/core2-64-poky-linux/containerd-opencontainers/v1.6.8+gitAUTOINC+579a6380ec-r0/git/src/import/cmd/ctr
That is being stored in the .rodata of the binaries.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Diffstat (limited to 'recipes-containers/containerd/containerd-opencontainers/0001-Add-build-option-GODEBUG-1.patch')
-rw-r--r-- | recipes-containers/containerd/containerd-opencontainers/0001-Add-build-option-GODEBUG-1.patch | 32 |
1 files changed, 0 insertions, 32 deletions
diff --git a/recipes-containers/containerd/containerd-opencontainers/0001-Add-build-option-GODEBUG-1.patch b/recipes-containers/containerd/containerd-opencontainers/0001-Add-build-option-GODEBUG-1.patch deleted file mode 100644 index 8b43c8a0..00000000 --- a/recipes-containers/containerd/containerd-opencontainers/0001-Add-build-option-GODEBUG-1.patch +++ /dev/null | |||
@@ -1,32 +0,0 @@ | |||
1 | From 84874e47aa2025b8e73df0286c44f3b8a1d9fdb2 Mon Sep 17 00:00:00 2001 | ||
2 | From: Hongxu Jia <hongxu.jia@windriver.com> | ||
3 | Date: Mon, 2 Sep 2019 16:20:07 +0800 | ||
4 | Subject: [PATCH] Add build option "GODEBUG=1" | ||
5 | |||
6 | Make will generate GDB friendly binary with this build option. | ||
7 | |||
8 | Signed-off-by: Hui Zhu <teawater@hyper.sh> | ||
9 | |||
10 | Upstream-Status: Backport [c5a0c7f491b435e4eb45972903b00e2d8ed46495] | ||
11 | |||
12 | Partly backport and refresh to v1.2.7 | ||
13 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> | ||
14 | --- | ||
15 | src/import/Makefile | 8 ++++++-- | ||
16 | 1 file changed, 6 insertions(+), 2 deletions(-) | ||
17 | |||
18 | Index: git/src/import/Makefile | ||
19 | =================================================================== | ||
20 | --- git.orig/src/import/Makefile 2020-10-12 08:09:41.638977052 -0700 | ||
21 | +++ git/src/import/Makefile 2020-10-12 08:10:49.783074373 -0700 | ||
22 | @@ -72,6 +72,10 @@ | ||
23 | COMMANDS=ctr containerd containerd-stress | ||
24 | MANPAGES=ctr.8 containerd.8 containerd-config.8 containerd-config.toml.5 | ||
25 | |||
26 | +ifndef GODEBUG | ||
27 | + EXTRA_LDFLAGS += -s -w | ||
28 | +endif | ||
29 | + | ||
30 | ifdef BUILDTAGS | ||
31 | GO_BUILDTAGS = ${BUILDTAGS} | ||
32 | endif | ||