diff options
author | Trevor Woerner <trevor.woerner@amd.com> | 2024-09-18 13:56:25 -0600 |
---|---|---|
committer | Mark Hatle <mark.hatle@amd.com> | 2024-09-19 18:49:19 -0500 |
commit | 83d27403e8acefc9474c9292d43f018e140370ee (patch) | |
tree | d31902774c2f9f83b6367d4cdde2966638f6eef9 | |
parent | b9214cd76dc7db351494b245690e1c1459a9eeb2 (diff) | |
download | meta-xilinx-83d27403e8acefc9474c9292d43f018e140370ee.tar.gz |
meta-xilinx-demos: meta-ros2-jazzy: mcap-vendor: fix build
The rosbag2/mcap-vendor build was failing due to being unable to
find the requested commit hash.
The originally-generated recipe was mostly correct, but was overridden by a
bbappend, in upstream meta-ros/meta-ros2-jazzy, which replaced the hash with
one from the release/rolling/mcap_vendor/0.24.0-1 branch.
The jazzy branch of meta-ros2 was created from the rolling release branch,
which is why the rosbag2/mcap-vendor recipe had an override which specified
a commit from the rolling branch of rosbag2-release. This wasn't updated to
point to a commit on the jazzy branch when the jazzy branch was created.
Update the SRCREV to point to a release on the release/jazzy/mcap_vendor
branch of rosbag2-release Also, update to the latest commit on this branch.
Additionally the build was failing because it was not able to find necessary
header files that were provided in the source tree.
Signed-off-by: Trevor Woerner <trevor.woerner@amd.com>
Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com>
Signed-off-by: Mark Hatle <mark.hatle@amd.com>
2 files changed, 33 insertions, 0 deletions
diff --git a/meta-xilinx-demos/dynamic-layers/meta-ros/meta-ros2-jazzy/recipes-bbappends/rosbag2/mcap-vendor/0001-fix-include-dir.patch b/meta-xilinx-demos/dynamic-layers/meta-ros/meta-ros2-jazzy/recipes-bbappends/rosbag2/mcap-vendor/0001-fix-include-dir.patch new file mode 100644 index 00000000..35650c23 --- /dev/null +++ b/meta-xilinx-demos/dynamic-layers/meta-ros/meta-ros2-jazzy/recipes-bbappends/rosbag2/mcap-vendor/0001-fix-include-dir.patch | |||
@@ -0,0 +1,27 @@ | |||
1 | From f15236807f0b5ac96979840a12cd0be0c115f055 Mon Sep 17 00:00:00 2001 | ||
2 | From: Trevor Woerner <trevor.woerner@amd.com> | ||
3 | Date: Thu, 12 Sep 2024 15:21:33 -0400 | ||
4 | Subject: [PATCH] fix include dir | ||
5 | |||
6 | Upstream-Status: inappropriate | ||
7 | Signed-off-by: Trevor Woerner <trevor.woerner@amd.com> | ||
8 | --- | ||
9 | CMakeLists.txt | 2 +- | ||
10 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
11 | |||
12 | diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
13 | index d5789b292025..e5e97fa9fa0f 100644 | ||
14 | --- a/CMakeLists.txt | ||
15 | +++ b/CMakeLists.txt | ||
16 | @@ -43,7 +43,7 @@ macro(build_mcap_vendor) | ||
17 | src/main.cpp | ||
18 | ) | ||
19 | |||
20 | - set(_mcap_include_dir ${mcap_SOURCE_DIR}/cpp/mcap/include) | ||
21 | + set(_mcap_include_dir ${mcap_vendor_SOURCE_DIR}/mcap/cpp/mcap/include) | ||
22 | file(GLOB _mcap_installed_headers ${_mcap_include_dir}/mcap/*.hpp) | ||
23 | |||
24 | target_include_directories(mcap PUBLIC | ||
25 | -- | ||
26 | 2.44.0.478.g7774cfed6261 | ||
27 | |||
diff --git a/meta-xilinx-demos/dynamic-layers/meta-ros/meta-ros2-jazzy/recipes-bbappends/rosbag2/mcap-vendor_%.bbappend b/meta-xilinx-demos/dynamic-layers/meta-ros/meta-ros2-jazzy/recipes-bbappends/rosbag2/mcap-vendor_%.bbappend new file mode 100644 index 00000000..dc63cf76 --- /dev/null +++ b/meta-xilinx-demos/dynamic-layers/meta-ros/meta-ros2-jazzy/recipes-bbappends/rosbag2/mcap-vendor_%.bbappend | |||
@@ -0,0 +1,6 @@ | |||
1 | FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" | ||
2 | |||
3 | B = "${S}" | ||
4 | SRC_URI:remove = "file://0001-CMakeLists.txt-fetch-dependencies-with-bitbake-fetch.patch" | ||
5 | SRC_URI:append = " file://0001-fix-include-dir.patch" | ||
6 | SRCREV_release:forcevariable = "6884e7ba7d29d8db98ad2bbf09a6875bf5141e19" | ||