summaryrefslogtreecommitdiffstats
path: root/bitbake/lib
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2024-10-18 11:42:51 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2024-10-24 11:24:03 +0100
commit4d9ad3bb8efbdab1cda677a870bac63012bf034c (patch)
tree7bc1fd77221fcd12f3ee2b62758aaa3515e7dd34 /bitbake/lib
parentd230085ed9260d5968b680d7cf91a0c1c06043ed (diff)
downloadpoky-4d9ad3bb8efbdab1cda677a870bac63012bf034c.tar.gz
bitbake: toaster/tests/functional/helpers: Drop unneeded poll values and sleep
Drop the remaining poll values and the sleep within the main wait function as the races this was working around now seem to be resolved with the preceeding patches. (Bitbake rev: 91e54cbacc57316a4f2ca766afac81e7f3a54718) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib')
-rw-r--r--bitbake/lib/toaster/tests/browser/selenium_helpers_base.py1
-rw-r--r--bitbake/lib/toaster/tests/functional/functional_helpers.py4
2 files changed, 2 insertions, 3 deletions
diff --git a/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py b/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py
index b060133b1d..5a4a4ef8b4 100644
--- a/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py
+++ b/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py
@@ -225,7 +225,6 @@ class SeleniumTestCaseBase(unittest.TestCase):
225 is_visible = lambda driver: self.find(selector).is_displayed() 225 is_visible = lambda driver: self.find(selector).is_displayed()
226 msg = 'An element matching "%s" should be visible' % selector 226 msg = 'An element matching "%s" should be visible' % selector
227 Wait(self.driver, poll=poll).until(is_visible, msg) 227 Wait(self.driver, poll=poll).until(is_visible, msg)
228 time.sleep(poll) # wait for visibility to settle
229 return self.find(selector) 228 return self.find(selector)
230 229
231 def wait_until_clickable(self, selector, poll=1): 230 def wait_until_clickable(self, selector, poll=1):
diff --git a/bitbake/lib/toaster/tests/functional/functional_helpers.py b/bitbake/lib/toaster/tests/functional/functional_helpers.py
index cc508e98d9..a7a3459630 100644
--- a/bitbake/lib/toaster/tests/functional/functional_helpers.py
+++ b/bitbake/lib/toaster/tests/functional/functional_helpers.py
@@ -167,7 +167,7 @@ class SeleniumFunctionalTestCase(SeleniumTestCaseBase):
167 self.assertEqual(del_response.status_code, 200) 167 self.assertEqual(del_response.status_code, 200)
168 168
169 self.get(reverse('newproject')) 169 self.get(reverse('newproject'))
170 self.wait_until_visible('#new-project-name', poll=3) 170 self.wait_until_visible('#new-project-name')
171 self.driver.find_element(By.ID, 171 self.driver.find_element(By.ID,
172 "new-project-name").send_keys(project_name) 172 "new-project-name").send_keys(project_name)
173 173
@@ -187,7 +187,7 @@ class SeleniumFunctionalTestCase(SeleniumTestCaseBase):
187 187
188 self.driver.find_element(By.ID, "create-project-button").click() 188 self.driver.find_element(By.ID, "create-project-button").click()
189 189
190 element = self.wait_until_visible('#project-created-notification', poll=3) 190 element = self.wait_until_visible('#project-created-notification')
191 self.assertTrue( 191 self.assertTrue(
192 self.element_exists('#project-created-notification'), 192 self.element_exists('#project-created-notification'),
193 f"Project:{project_name} creation notification not shown" 193 f"Project:{project_name} creation notification not shown"