summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Kutik <daniel.kutik@lavawerk.com>2022-11-27 13:31:48 +0100
committerDaniel Kutik <daniel.kutik@lavawerk.com>2022-11-27 17:03:41 +0000
commit003684b6e5aad4a4f44b77a3148f24fed97f060a (patch)
treeb6b494efb77899624b78b304ef969c862e757d0e
parent0297f8312c5cd80cf5d2ffc3f0915b00647b03e5 (diff)
downloadgit-repo-003684b6e5aad4a4f44b77a3148f24fed97f060a.tar.gz
test: Fix char encoding issues on windows
Some tests were failing due to Windows not using utf-8 by default when executing the tests. Enforcing usage of utf-8 resolves these issues. Signed-off-by: Daniel Kutik <daniel.kutik@lavawerk.com> Change-Id: If42f6be2a2b688a6105ecf4fcdb541aade24519a Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/353179 Reviewed-by: Mike Frysinger <vapier@google.com>
-rw-r--r--tests/test_manifest_xml.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/test_manifest_xml.py b/tests/test_manifest_xml.py
index 0e649a67..8aa97e70 100644
--- a/tests/test_manifest_xml.py
+++ b/tests/test_manifest_xml.py
@@ -117,7 +117,7 @@ class ManifestParseTestCase(unittest.TestCase):
117 117
118 def getXmlManifest(self, data): 118 def getXmlManifest(self, data):
119 """Helper to initialize a manifest for testing.""" 119 """Helper to initialize a manifest for testing."""
120 with open(self.manifest_file, 'w') as fp: 120 with open(self.manifest_file, 'w', encoding="utf-8") as fp:
121 fp.write(data) 121 fp.write(data)
122 return manifest_xml.XmlManifest(self.repodir, self.manifest_file) 122 return manifest_xml.XmlManifest(self.repodir, self.manifest_file)
123 123
@@ -428,7 +428,7 @@ class IncludeElementTests(ManifestParseTestCase):
428 def parse(name): 428 def parse(name):
429 name = self.encodeXmlAttr(name) 429 name = self.encodeXmlAttr(name)
430 # Setup target of the include. 430 # Setup target of the include.
431 with open(os.path.join(self.manifest_dir, 'target.xml'), 'w') as fp: 431 with open(os.path.join(self.manifest_dir, 'target.xml'), 'w', encoding="utf-8") as fp:
432 fp.write(f'<manifest><include name="{name}"/></manifest>') 432 fp.write(f'<manifest><include name="{name}"/></manifest>')
433 433
434 manifest = self.getXmlManifest(""" 434 manifest = self.getXmlManifest("""