diff options
author | Mike Frysinger <vapier@google.com> | 2025-03-25 12:58:26 -0400 |
---|---|---|
committer | LUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2025-03-25 10:07:42 -0700 |
commit | 91f428058d7d23709c057850580fe0315bd74f76 (patch) | |
tree | b32c0ba4d4fbb418c95b8c9b46cab898cdeaa8c0 | |
parent | 243df2042ed756e7829cd39d3ebe3d1919444d5d (diff) | |
download | git-repo-91f428058d7d23709c057850580fe0315bd74f76.tar.gz |
run_tests: run all tests all the time
Using a generator w/all() causes the code to exit on the first error.
We really want to see all errors all the time, so use sum() instead.
Change-Id: Ib1adb8de199db9fe727d4b49c890b4d5061e9e6b
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/462901
Tested-by: Mike Frysinger <vapier@google.com>
Commit-Queue: Mike Frysinger <vapier@google.com>
Reviewed-by: Scott Lee <ddoman@google.com>
-rwxr-xr-x | run_tests | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -63,7 +63,9 @@ def main(argv): | |||
63 | run_flake8, | 63 | run_flake8, |
64 | run_isort, | 64 | run_isort, |
65 | ) | 65 | ) |
66 | return 0 if all(not c() for c in checks) else 1 | 66 | # Run all the tests all the time to get full feedback. Don't exit on the |
67 | # first error as that makes it more difficult to iterate in the CQ. | ||
68 | return 1 if sum(c() for c in checks) else 0 | ||
67 | 69 | ||
68 | 70 | ||
69 | if __name__ == "__main__": | 71 | if __name__ == "__main__": |