diff options
author | David Holmer <odinguru@gmail.com> | 2012-09-26 01:58:48 -0400 |
---|---|---|
committer | David Holmer <odinguru@gmail.com> | 2012-09-26 01:58:48 -0400 |
commit | 9779565abf06d2f1e48548197be350a06c1eab9b (patch) | |
tree | 2df81e18395ef2a4782e0a889abaaebcea0e40f1 | |
parent | cf76b1bcec6386f9530636e64746502f9856b5cf (diff) | |
download | git-repo-9779565abf06d2f1e48548197be350a06c1eab9b.tar.gz |
Fix incorrect default_groups when parsing projects from XML manifest
Change Details:
* Switch first default group to 'all' instead of 'default'
Change Benefits:
* More consistent with default_groups in the counterpart Save() function
* Fixes bug where command 'repo manifest' added an extra 'default'
group to every output project element groups attribute. This bug was
particularly confusing for projects which had 'groups="notdefault"'
as they were output as 'groups="notdefault,default"' by 'repo manifest'
Change-Id: I5611c027a982d3394899466248b971910bec8c6b
-rw-r--r-- | manifest_xml.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/manifest_xml.py b/manifest_xml.py index f4f6a755..8be83cf9 100644 --- a/manifest_xml.py +++ b/manifest_xml.py | |||
@@ -579,7 +579,7 @@ class XmlManifest(object): | |||
579 | groups = node.getAttribute('groups') | 579 | groups = node.getAttribute('groups') |
580 | groups = [x for x in re.split('[,\s]+', groups) if x] | 580 | groups = [x for x in re.split('[,\s]+', groups) if x] |
581 | 581 | ||
582 | default_groups = ['default', 'name:%s' % name, 'path:%s' % path] | 582 | default_groups = ['all', 'name:%s' % name, 'path:%s' % path] |
583 | groups.extend(set(default_groups).difference(groups)) | 583 | groups.extend(set(default_groups).difference(groups)) |
584 | 584 | ||
585 | if self.IsMirror: | 585 | if self.IsMirror: |