diff options
author | David Pursehouse <dpursehouse@collab.net> | 2020-02-13 10:34:05 +0900 |
---|---|---|
committer | David Pursehouse <dpursehouse@collab.net> | 2020-02-13 04:12:22 +0000 |
commit | daa2cecdc5b8dad4361f9dd0c9acf4dd7a508729 (patch) | |
tree | 40a239873bd1b314faf70ba8383fea2b87886c1d /SUBMITTING_PATCHES.md | |
parent | 3c5114cd787abf9abc8c4c0cf2a285be9532aeef (diff) | |
download | git-repo-daa2cecdc5b8dad4361f9dd0c9acf4dd7a508729.tar.gz |
Mention exceptions to Google Style Guide in SUBMITTING_PATCHES.md
Change-Id: I05d313c66f312942405a884a54118cb1d7af1bac
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254671
Tested-by: David Pursehouse <dpursehouse@collab.net>
Reviewed-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'SUBMITTING_PATCHES.md')
-rw-r--r-- | SUBMITTING_PATCHES.md | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/SUBMITTING_PATCHES.md b/SUBMITTING_PATCHES.md index 5021e7ee..316cb620 100644 --- a/SUBMITTING_PATCHES.md +++ b/SUBMITTING_PATCHES.md | |||
@@ -55,9 +55,14 @@ Run `flake8` on changes modules: | |||
55 | flake8 file.py | 55 | flake8 file.py |
56 | 56 | ||
57 | Note that repo generally follows [Google's python style guide] rather than | 57 | Note that repo generally follows [Google's python style guide] rather than |
58 | [PEP 8], so it's possible that the output of `flake8` will be quite noisy. | 58 | [PEP 8], with a couple of notable exceptions: |
59 | It's not mandatory to avoid all warnings, but at least the maximum line | 59 | |
60 | length should be followed. | 60 | * Indentation is at 2 columns rather than 4 |
61 | * The maximum line length is 100 columns rather than 80 | ||
62 | |||
63 | It's possible that the output of `flake8` will be quite noisy, so it's not | ||
64 | mandatory to avoid all warnings, but at least the maximum line length | ||
65 | should be followed. | ||
61 | 66 | ||
62 | If there are many occurrences of the same warning that cannot be | 67 | If there are many occurrences of the same warning that cannot be |
63 | avoided without going against the Google style guide, these may be | 68 | avoided without going against the Google style guide, these may be |