diff options
author | Chirayu Desai <cdesai@cyanogenmod.org> | 2013-03-01 19:14:38 +0530 |
---|---|---|
committer | Chirayu Desai <cdesai@cyanogenmod.org> | 2013-04-18 21:35:49 +0530 |
commit | 217ea7d2747e3098009afe0b389fc4b45f55ea5a (patch) | |
tree | 4ea2663a01fb22002ec6cd6ede9cb3babd89a692 /git_refs.py | |
parent | fef4ae74e26efecf5c803793351b6c843eab4970 (diff) | |
download | git-repo-217ea7d2747e3098009afe0b389fc4b45f55ea5a.tar.gz |
Some fixes for supporting python3
* Fix imports.
* Use python3 syntax.
* Wrap map() calls with list().
* Use list() only wherever needed.
(Thanks Conley!)
* Fix dictionary iteration methods
(s/iteritems/items/).
* Make use of sorted() in appropriate places
* Use iterators directly in the loop.
* Don't use .keys() wherever it isn't needed.
* Use sys.maxsize instead of sys.maxint
TODO:
* Make repo work fully with python3. :)
Some of this was done by the '2to3' tool [1], by
applying the needed fixes in a way that doesn't
break compatibility with python2.
Links:
[1]: http://docs.python.org/2/library/2to3.html
Change-Id: Ibdf3bf9a530d716db905733cb9bfef83a48820f7
Signed-off-by: Chirayu Desai <cdesai@cyanogenmod.org>
Diffstat (limited to 'git_refs.py')
-rw-r--r-- | git_refs.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/git_refs.py b/git_refs.py index cfeffba9..4dd68769 100644 --- a/git_refs.py +++ b/git_refs.py | |||
@@ -66,7 +66,7 @@ class GitRefs(object): | |||
66 | def _NeedUpdate(self): | 66 | def _NeedUpdate(self): |
67 | Trace(': scan refs %s', self._gitdir) | 67 | Trace(': scan refs %s', self._gitdir) |
68 | 68 | ||
69 | for name, mtime in self._mtime.iteritems(): | 69 | for name, mtime in self._mtime.items(): |
70 | try: | 70 | try: |
71 | if mtime != os.path.getmtime(os.path.join(self._gitdir, name)): | 71 | if mtime != os.path.getmtime(os.path.join(self._gitdir, name)): |
72 | return True | 72 | return True |
@@ -89,7 +89,7 @@ class GitRefs(object): | |||
89 | attempts = 0 | 89 | attempts = 0 |
90 | while scan and attempts < 5: | 90 | while scan and attempts < 5: |
91 | scan_next = {} | 91 | scan_next = {} |
92 | for name, dest in scan.iteritems(): | 92 | for name, dest in scan.items(): |
93 | if dest in self._phyref: | 93 | if dest in self._phyref: |
94 | self._phyref[name] = self._phyref[dest] | 94 | self._phyref[name] = self._phyref[dest] |
95 | else: | 95 | else: |
@@ -108,6 +108,7 @@ class GitRefs(object): | |||
108 | return | 108 | return |
109 | try: | 109 | try: |
110 | for line in fd: | 110 | for line in fd: |
111 | line = str(line) | ||
111 | if line[0] == '#': | 112 | if line[0] == '#': |
112 | continue | 113 | continue |
113 | if line[0] == '^': | 114 | if line[0] == '^': |
@@ -150,6 +151,10 @@ class GitRefs(object): | |||
150 | finally: | 151 | finally: |
151 | fd.close() | 152 | fd.close() |
152 | 153 | ||
154 | try: | ||
155 | ref_id = ref_id.decode() | ||
156 | except AttributeError: | ||
157 | pass | ||
153 | if not ref_id: | 158 | if not ref_id: |
154 | return | 159 | return |
155 | ref_id = ref_id[:-1] | 160 | ref_id = ref_id[:-1] |