diff options
author | David Pursehouse <david.pursehouse@sonymobile.com> | 2012-10-11 16:44:48 +0900 |
---|---|---|
committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2012-10-22 12:30:14 +0900 |
commit | 5c6eeac8f0350fd6b14cf226ffcff655f1dd9582 (patch) | |
tree | 3225695b9d2a97342a49127717ea5e2bc5935a63 /manifest_xml.py | |
parent | e98607248eec2b149d84efe944c12cbef419b82e (diff) | |
download | git-repo-5c6eeac8f0350fd6b14cf226ffcff655f1dd9582.tar.gz |
More coding style cleanup
Fixing more issues found with pylint. Some that were supposed to
have been fixed in the previous sweep (Ie0db839e) but were missed:
C0321: More than one statement on a single line
W0622: Redefining built-in 'name'
And some more:
W0631: Using possibly undefined loop variable 'name'
W0223: Method 'name' is abstract in class 'name' but is not overridden
W0231: __init__ method from base class 'name' is not called
Change-Id: Ie119183708609d6279e973057a385fde864230c3
Diffstat (limited to 'manifest_xml.py')
-rw-r--r-- | manifest_xml.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/manifest_xml.py b/manifest_xml.py index 12072441..04cabaad 100644 --- a/manifest_xml.py +++ b/manifest_xml.py | |||
@@ -321,7 +321,8 @@ class XmlManifest(object): | |||
321 | raise ManifestParseError("no <manifest> in %s" % (path,)) | 321 | raise ManifestParseError("no <manifest> in %s" % (path,)) |
322 | 322 | ||
323 | nodes = [] | 323 | nodes = [] |
324 | for node in manifest.childNodes: | 324 | for node in manifest.childNodes: # pylint:disable-msg=W0631 |
325 | # We only get here if manifest is initialised | ||
325 | if node.nodeName == 'include': | 326 | if node.nodeName == 'include': |
326 | name = self._reqatt(node, 'name') | 327 | name = self._reqatt(node, 'name') |
327 | fp = os.path.join(include_root, name) | 328 | fp = os.path.join(include_root, name) |