diff options
author | Mike Frysinger <vapier@google.com> | 2022-08-19 02:11:35 -0400 |
---|---|---|
committer | Mike Frysinger <vapier@google.com> | 2022-08-22 19:34:59 +0000 |
commit | 63a5657ecfe1585ceda3231bfe8a6c8d9c3dafad (patch) | |
tree | 76642924ef5d6578e151dce1cecd0c3d1e408527 /manifest_xml.py | |
parent | 07d21e6bde9bd7efdfb8f25f2ed23f023daa5c1f (diff) | |
download | git-repo-63a5657ecfe1585ceda3231bfe8a6c8d9c3dafad.tar.gz |
git_command: fix input passing
After reworking this function to use subprocess for output capturing
in commit c87c1863b1df392042c8859b81475a65315c8a9d ("git_command:
switch process capturing over to subprocess"), passing input via
stdin write no longer works. We have to pass it via communicate(),
and we have to pass it a string instead of bytes (since we always
use encoding='utf-8' now). This is fine since the only user of the
input= setting today is already passing in a string.
Bug: https://crbug.com/gerrit/16151
Change-Id: Ic58db1e568b8f8aa840a6d62c5a157c14aa6d9bc
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/343515
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: LaMont Jones <lamontjones@google.com>
Diffstat (limited to 'manifest_xml.py')
0 files changed, 0 insertions, 0 deletions