summaryrefslogtreecommitdiffstats
path: root/project.py
diff options
context:
space:
mode:
authorShawn O. Pearce <sop@google.com>2008-11-11 17:03:13 -0800
committerShawn O. Pearce <sop@google.com>2008-11-12 09:12:17 -0800
commit35f2596c27ae041235b88076888870b8ba2e2c8c (patch)
treee404e569a49057d44b88c2cfae7f7f817c566326 /project.py
parent5d40e26201ed87ae8276a77e263b8cbe50598703 (diff)
downloadgit-repo-35f2596c27ae041235b88076888870b8ba2e2c8c.tar.gz
Refactor part of GetUploadableBranches to lookup one specific branch
This way project.GetUploadableBranch(project.CurrentBranch) can tell us how (if at all) to upload the currently checked out branch. Signed-off-by: Shawn O. Pearce <sop@google.com>
Diffstat (limited to 'project.py')
-rw-r--r--project.py20
1 files changed, 14 insertions, 6 deletions
diff --git a/project.py b/project.py
index 9509cb98..1e25c2c9 100644
--- a/project.py
+++ b/project.py
@@ -428,14 +428,22 @@ class Project(object):
428 if branch in pubed and pubed[branch] == id: 428 if branch in pubed and pubed[branch] == id:
429 continue 429 continue
430 430
431 branch = self.GetBranch(branch) 431 rb = self.GetUploadableBranch(branch)
432 base = branch.LocalMerge 432 if rb:
433 if branch.LocalMerge: 433 ready.append(rb)
434 rb = ReviewableBranch(self, branch, base)
435 if rb.commits:
436 ready.append(rb)
437 return ready 434 return ready
438 435
436 def GetUploadableBranch(self, branch_name):
437 """Get a single uploadable branch, or None.
438 """
439 branch = self.GetBranch(branch_name)
440 base = branch.LocalMerge
441 if branch.LocalMerge:
442 rb = ReviewableBranch(self, branch, base)
443 if rb.commits:
444 return rb
445 return None
446
439 def UploadForReview(self, branch=None): 447 def UploadForReview(self, branch=None):
440 """Uploads the named branch for code review. 448 """Uploads the named branch for code review.
441 """ 449 """