diff options
author | Mike Frysinger <vapier@google.com> | 2020-02-09 16:20:06 -0500 |
---|---|---|
committer | Mike Frysinger <vapier@google.com> | 2020-02-12 02:00:16 +0000 |
commit | dc1d0e0c7fffa5109048ac52a67aa97bb362ae3a (patch) | |
tree | 5daa113a15b79a6014656da07a9e11762bd36198 /project.py | |
parent | 82caef67a16437b9c39e1f2c920cc6307767b1d6 (diff) | |
download | git-repo-dc1d0e0c7fffa5109048ac52a67aa97bb362ae3a.tar.gz |
Revert "Save cookies back to jar when fetching clone.bundle"v2.2
This reverts commit 4abf8e6ef81e78469148b156ae2d2da70ace627a.
The curl process for updating the cookie file is not atomic. When
fetching many bundles in parallel, we can sometimes corrupt the file
causing it to be cleared. Since users should manage gitcookies on
their own, leave it read-only.
Bug: https://crbug.com/gerrit/12300
Change-Id: Id472c99b197bc4cf8533c649f8881509f38643c1
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254092
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Tested-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'project.py')
-rw-r--r-- | project.py | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -2482,7 +2482,7 @@ class Project(object): | |||
2482 | platform_utils.remove(tmpPath) | 2482 | platform_utils.remove(tmpPath) |
2483 | with GetUrlCookieFile(srcUrl, quiet) as (cookiefile, proxy): | 2483 | with GetUrlCookieFile(srcUrl, quiet) as (cookiefile, proxy): |
2484 | if cookiefile: | 2484 | if cookiefile: |
2485 | cmd += ['--cookie', cookiefile, '--cookie-jar', cookiefile] | 2485 | cmd += ['--cookie', cookiefile] |
2486 | if proxy: | 2486 | if proxy: |
2487 | cmd += ['--proxy', proxy] | 2487 | cmd += ['--proxy', proxy] |
2488 | elif 'http_proxy' in os.environ and 'darwin' == sys.platform: | 2488 | elif 'http_proxy' in os.environ and 'darwin' == sys.platform: |