diff options
author | Mike Frysinger <vapier@google.com> | 2020-02-17 14:36:08 -0500 |
---|---|---|
committer | David Pursehouse <dpursehouse@collab.net> | 2020-02-19 00:24:43 +0000 |
commit | c58ec4dba102d88fec67e833eb8421202eb4c1ea (patch) | |
tree | c8c84e03f9359ae9dd126854069d34207c298831 /repo | |
parent | e1191b3adb22e0b406db87691b13ddab2c236267 (diff) | |
download | git-repo-c58ec4dba102d88fec67e833eb8421202eb4c1ea.tar.gz |
avoid negative variables
Trying to use booleans with names like "no_xxx" are hard to follow due
to the double negatives. Invert all of them so we only have positive
meanings to follow.
Change-Id: Ifd37d0368f97034d94aa2cf38db52c723ac0c6ed
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255493
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Diffstat (limited to 'repo')
-rwxr-xr-x | repo | 13 |
1 files changed, 8 insertions, 5 deletions
@@ -315,9 +315,11 @@ def GetParser(gitc_init=False): | |||
315 | help='restrict manifest projects to ones with a specified ' | 315 | help='restrict manifest projects to ones with a specified ' |
316 | 'platform group [auto|all|none|linux|darwin|...]', | 316 | 'platform group [auto|all|none|linux|darwin|...]', |
317 | metavar='PLATFORM') | 317 | metavar='PLATFORM') |
318 | group.add_option('--no-clone-bundle', action='store_true', | 318 | group.add_option('--no-clone-bundle', |
319 | dest='clone_bundle', default=True, action='store_false', | ||
319 | help='disable use of /clone.bundle on HTTP/HTTPS') | 320 | help='disable use of /clone.bundle on HTTP/HTTPS') |
320 | group.add_option('--no-tags', action='store_true', | 321 | group.add_option('--no-tags', |
322 | dest='tags', default=True, action='store_false', | ||
321 | help="don't fetch tags in the manifest") | 323 | help="don't fetch tags in the manifest") |
322 | 324 | ||
323 | # Tool. | 325 | # Tool. |
@@ -326,7 +328,8 @@ def GetParser(gitc_init=False): | |||
326 | help='repo repository location ($REPO_URL)') | 328 | help='repo repository location ($REPO_URL)') |
327 | group.add_option('--repo-branch', metavar='REVISION', | 329 | group.add_option('--repo-branch', metavar='REVISION', |
328 | help='repo branch or revision ($REPO_REV)') | 330 | help='repo branch or revision ($REPO_REV)') |
329 | group.add_option('--no-repo-verify', action='store_true', | 331 | group.add_option('--no-repo-verify', |
332 | dest='repo_verify', default=True, action='store_false', | ||
330 | help='do not verify repo source code') | 333 | help='do not verify repo source code') |
331 | 334 | ||
332 | # Other. | 335 | # Other. |
@@ -505,7 +508,7 @@ def _Init(args, gitc_init=False): | |||
505 | 508 | ||
506 | _CheckGitVersion() | 509 | _CheckGitVersion() |
507 | try: | 510 | try: |
508 | if opt.no_repo_verify: | 511 | if not opt.repo_verify: |
509 | do_verify = False | 512 | do_verify = False |
510 | else: | 513 | else: |
511 | if NeedSetupGnuPG(): | 514 | if NeedSetupGnuPG(): |
@@ -514,7 +517,7 @@ def _Init(args, gitc_init=False): | |||
514 | do_verify = True | 517 | do_verify = True |
515 | 518 | ||
516 | dst = os.path.abspath(os.path.join(repodir, S_repo)) | 519 | dst = os.path.abspath(os.path.join(repodir, S_repo)) |
517 | _Clone(url, dst, opt.quiet, not opt.no_clone_bundle) | 520 | _Clone(url, dst, opt.quiet, opt.clone_bundle) |
518 | 521 | ||
519 | if do_verify: | 522 | if do_verify: |
520 | rev = _Verify(dst, branch, opt.quiet) | 523 | rev = _Verify(dst, branch, opt.quiet) |