summaryrefslogtreecommitdiffstats
path: root/subcmds/branches.py
diff options
context:
space:
mode:
authorDavid Pursehouse <david.pursehouse@sonymobile.com>2012-10-11 16:44:48 +0900
committerDavid Pursehouse <david.pursehouse@sonymobile.com>2012-10-22 12:30:14 +0900
commit5c6eeac8f0350fd6b14cf226ffcff655f1dd9582 (patch)
tree3225695b9d2a97342a49127717ea5e2bc5935a63 /subcmds/branches.py
parente98607248eec2b149d84efe944c12cbef419b82e (diff)
downloadgit-repo-5c6eeac8f0350fd6b14cf226ffcff655f1dd9582.tar.gz
More coding style cleanup
Fixing more issues found with pylint. Some that were supposed to have been fixed in the previous sweep (Ie0db839e) but were missed: C0321: More than one statement on a single line W0622: Redefining built-in 'name' And some more: W0631: Using possibly undefined loop variable 'name' W0223: Method 'name' is abstract in class 'name' but is not overridden W0231: __init__ method from base class 'name' is not called Change-Id: Ie119183708609d6279e973057a385fde864230c3
Diffstat (limited to 'subcmds/branches.py')
-rw-r--r--subcmds/branches.py12
1 files changed, 6 insertions, 6 deletions
diff --git a/subcmds/branches.py b/subcmds/branches.py
index 81aa5b18..a7ba3d6d 100644
--- a/subcmds/branches.py
+++ b/subcmds/branches.py
@@ -93,17 +93,17 @@ is shown, then the branch appears in all projects.
93 def Execute(self, opt, args): 93 def Execute(self, opt, args):
94 projects = self.GetProjects(args) 94 projects = self.GetProjects(args)
95 out = BranchColoring(self.manifest.manifestProject.config) 95 out = BranchColoring(self.manifest.manifestProject.config)
96 all = {} 96 all_branches = {}
97 project_cnt = len(projects) 97 project_cnt = len(projects)
98 98
99 for project in projects: 99 for project in projects:
100 for name, b in project.GetBranches().iteritems(): 100 for name, b in project.GetBranches().iteritems():
101 b.project = project 101 b.project = project
102 if name not in all: 102 if name not in all_branches:
103 all[name] = BranchInfo(name) 103 all_branches[name] = BranchInfo(name)
104 all[name].add(b) 104 all_branches[name].add(b)
105 105
106 names = all.keys() 106 names = all_branches.keys()
107 names.sort() 107 names.sort()
108 108
109 if not names: 109 if not names:
@@ -116,7 +116,7 @@ is shown, then the branch appears in all projects.
116 width = len(name) 116 width = len(name)
117 117
118 for name in names: 118 for name in names:
119 i = all[name] 119 i = all_branches[name]
120 in_cnt = len(i.projects) 120 in_cnt = len(i.projects)
121 121
122 if i.IsCurrent: 122 if i.IsCurrent: