diff options
| author | Jack Neus <jackneus@google.com> | 2021-10-25 22:38:44 +0000 |
|---|---|---|
| committer | Jack Neus <jackneus@google.com> | 2021-10-26 22:18:28 +0000 |
| commit | 198838599c5d4eaaa3bd68ff903925eeb4a09da9 (patch) | |
| tree | 2c7f8e448acb0881397f97a71e205b613aa747e5 /subcmds/grep.py | |
| parent | 282d0cae8913e9d20f526e7fb2633bb4e2a21fbf (diff) | |
| download | git-repo-198838599c5d4eaaa3bd68ff903925eeb4a09da9.tar.gz | |
fetch: Fix stderr handling for gsutil
Previously gsutil stderr was getting piped into stdout, which
yields bad results if there are non-fatal warnings in stderr.
Additionally, we should fail outright if gsutil fails (by adding
`check = True`) rather than fail later on when we try to sync to
a manifest that is in fact just a stderr dump.
BUG=none
TEST=manual runs with bad gs urls
Change-Id: Id71791d0c3f180bd0601ef2c783a8e8e4afa8f59
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/321935
Tested-by: Jack Neus <jackneus@google.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'subcmds/grep.py')
0 files changed, 0 insertions, 0 deletions