diff options
author | David Pursehouse <david.pursehouse@sonymobile.com> | 2012-09-24 12:15:13 +0900 |
---|---|---|
committer | Gustaf Lundh <gustaf.lundh@sonymobile.com> | 2012-10-09 12:45:30 +0200 |
commit | 8a68ff96057ec58e524a3e41a2d8dca7b5d016bc (patch) | |
tree | 22f6971e8d3c4a90d11d3704602d073a852328b4 /subcmds/manifest.py | |
parent | e3b1c45aebed329cbc9ad172b1d8e812cf208117 (diff) | |
download | git-repo-8a68ff96057ec58e524a3e41a2d8dca7b5d016bc.tar.gz |
Coding style cleanup
Fix the following issues reported by pylint:
C0321: More than one statement on a single line
W0622: Redefining built-in 'name'
W0612: Unused variable 'name'
W0613: Unused argument 'name'
W0102: Dangerous default value 'value' as argument
W0105: String statement has no effect
Also fixed a few cases of inconsistent indentation.
Change-Id: Ie0db839e7c57d576cff12d8c055fe87030d00744
Diffstat (limited to 'subcmds/manifest.py')
-rw-r--r-- | subcmds/manifest.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/subcmds/manifest.py b/subcmds/manifest.py index 43887654..5592a37d 100644 --- a/subcmds/manifest.py +++ b/subcmds/manifest.py | |||
@@ -35,14 +35,14 @@ in a Git repository for use during future 'repo init' invocations. | |||
35 | 35 | ||
36 | @property | 36 | @property |
37 | def helpDescription(self): | 37 | def helpDescription(self): |
38 | help = self._helpDescription + '\n' | 38 | helptext = self._helpDescription + '\n' |
39 | r = os.path.dirname(__file__) | 39 | r = os.path.dirname(__file__) |
40 | r = os.path.dirname(r) | 40 | r = os.path.dirname(r) |
41 | fd = open(os.path.join(r, 'docs', 'manifest-format.txt')) | 41 | fd = open(os.path.join(r, 'docs', 'manifest-format.txt')) |
42 | for line in fd: | 42 | for line in fd: |
43 | help += line | 43 | helptext += line |
44 | fd.close() | 44 | fd.close() |
45 | return help | 45 | return helptext |
46 | 46 | ||
47 | def _Options(self, p): | 47 | def _Options(self, p): |
48 | p.add_option('-r', '--revision-as-HEAD', | 48 | p.add_option('-r', '--revision-as-HEAD', |