summaryrefslogtreecommitdiffstats
path: root/subcmds/prune.py
diff options
context:
space:
mode:
authorKuang-che Wu <kcwu@google.com>2024-10-22 21:04:41 +0800
committerLUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com>2024-10-23 23:34:34 +0000
commit8da4861b3860c505e39341b4135c21f67569e4d8 (patch)
tree6f300266c91322df0e61953b84381e1f403074a5 /subcmds/prune.py
parent39ffd9977e2f6cb1ca1757e59173fc93e0eab72c (diff)
downloadgit-repo-8da4861b3860c505e39341b4135c21f67569e4d8.tar.gz
subcmds: reduce multiprocessing serialization overhead
Follow the same approach as 39ffd9977e to reduce serialization overhead. Below benchmarks are tested with 2.7k projects on my workstation (warm cache). git tracing is disabled for benchmark. (seconds) | v2.48 | v2.48 | this CL | this CL | | -j32 | | -j32 ----------------------------------------------------------- with clean tree state: branches (none) | 5.6 | 5.9 | 1.0 | 0.9 status (clean) | 21.3 | 9.4 | 19.4 | 4.7 diff (none) | 7.6 | 7.2 | 5.7 | 2.2 prune (none) | 5.7 | 6.1 | 1.3 | 1.2 abandon (none) | 19.4 | 18.6 | 0.9 | 0.8 upload (none) | 19.7 | 18.7 | 0.9 | 0.8 forall -c true | 7.5 | 7.6 | 0.6 | 0.6 forall -c "git log -1" | 11.3 | 11.1 | 0.6 | 0.6 with branches: start BRANCH --all | 21.9 | 20.3 | 13.6 | 2.6 checkout BRANCH | 29.1 | 27.8 | 1.1 | 1.0 branches (2) | 28.0 | 28.6 | 1.5 | 1.3 abandon BRANCH | 29.2 | 27.5 | 9.7 | 2.2 Bug: b/371638995 Change-Id: I53989a3d1e43063587b3f52f852b1c2c56b49412 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/440221 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Tested-by: Kuang-che Wu <kcwu@google.com> Commit-Queue: Kuang-che Wu <kcwu@google.com>
Diffstat (limited to 'subcmds/prune.py')
-rw-r--r--subcmds/prune.py20
1 files changed, 12 insertions, 8 deletions
diff --git a/subcmds/prune.py b/subcmds/prune.py
index f99082a4..18bfc680 100644
--- a/subcmds/prune.py
+++ b/subcmds/prune.py
@@ -27,8 +27,10 @@ class Prune(PagedCommand):
27""" 27"""
28 PARALLEL_JOBS = DEFAULT_LOCAL_JOBS 28 PARALLEL_JOBS = DEFAULT_LOCAL_JOBS
29 29
30 def _ExecuteOne(self, project): 30 @classmethod
31 def _ExecuteOne(cls, project_idx):
31 """Process one project.""" 32 """Process one project."""
33 project = cls.get_parallel_context()["projects"][project_idx]
32 return project.PruneHeads() 34 return project.PruneHeads()
33 35
34 def Execute(self, opt, args): 36 def Execute(self, opt, args):
@@ -41,13 +43,15 @@ class Prune(PagedCommand):
41 def _ProcessResults(_pool, _output, results): 43 def _ProcessResults(_pool, _output, results):
42 return list(itertools.chain.from_iterable(results)) 44 return list(itertools.chain.from_iterable(results))
43 45
44 all_branches = self.ExecuteInParallel( 46 with self.ParallelContext():
45 opt.jobs, 47 self.get_parallel_context()["projects"] = projects
46 self._ExecuteOne, 48 all_branches = self.ExecuteInParallel(
47 projects, 49 opt.jobs,
48 callback=_ProcessResults, 50 self._ExecuteOne,
49 ordered=True, 51 range(len(projects)),
50 ) 52 callback=_ProcessResults,
53 ordered=True,
54 )
51 55
52 if not all_branches: 56 if not all_branches:
53 return 57 return