diff options
author | Kuang-che Wu <kcwu@google.com> | 2024-10-22 21:04:41 +0800 |
---|---|---|
committer | LUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2024-10-23 23:34:34 +0000 |
commit | 8da4861b3860c505e39341b4135c21f67569e4d8 (patch) | |
tree | 6f300266c91322df0e61953b84381e1f403074a5 /subcmds/status.py | |
parent | 39ffd9977e2f6cb1ca1757e59173fc93e0eab72c (diff) | |
download | git-repo-8da4861b3860c505e39341b4135c21f67569e4d8.tar.gz |
subcmds: reduce multiprocessing serialization overhead
Follow the same approach as 39ffd9977e to reduce serialization overhead.
Below benchmarks are tested with 2.7k projects on my workstation
(warm cache). git tracing is disabled for benchmark.
(seconds) | v2.48 | v2.48 | this CL | this CL
| | -j32 | | -j32
-----------------------------------------------------------
with clean tree state:
branches (none) | 5.6 | 5.9 | 1.0 | 0.9
status (clean) | 21.3 | 9.4 | 19.4 | 4.7
diff (none) | 7.6 | 7.2 | 5.7 | 2.2
prune (none) | 5.7 | 6.1 | 1.3 | 1.2
abandon (none) | 19.4 | 18.6 | 0.9 | 0.8
upload (none) | 19.7 | 18.7 | 0.9 | 0.8
forall -c true | 7.5 | 7.6 | 0.6 | 0.6
forall -c "git log -1" | 11.3 | 11.1 | 0.6 | 0.6
with branches:
start BRANCH --all | 21.9 | 20.3 | 13.6 | 2.6
checkout BRANCH | 29.1 | 27.8 | 1.1 | 1.0
branches (2) | 28.0 | 28.6 | 1.5 | 1.3
abandon BRANCH | 29.2 | 27.5 | 9.7 | 2.2
Bug: b/371638995
Change-Id: I53989a3d1e43063587b3f52f852b1c2c56b49412
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/440221
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Tested-by: Kuang-che Wu <kcwu@google.com>
Commit-Queue: Kuang-che Wu <kcwu@google.com>
Diffstat (limited to 'subcmds/status.py')
-rw-r--r-- | subcmds/status.py | 27 |
1 files changed, 16 insertions, 11 deletions
diff --git a/subcmds/status.py b/subcmds/status.py index dac61ab6..cda73627 100644 --- a/subcmds/status.py +++ b/subcmds/status.py | |||
@@ -88,7 +88,8 @@ the following meanings: | |||
88 | "projects", | 88 | "projects", |
89 | ) | 89 | ) |
90 | 90 | ||
91 | def _StatusHelper(self, quiet, local, project): | 91 | @classmethod |
92 | def _StatusHelper(cls, quiet, local, project_idx): | ||
92 | """Obtains the status for a specific project. | 93 | """Obtains the status for a specific project. |
93 | 94 | ||
94 | Obtains the status for a project, redirecting the output to | 95 | Obtains the status for a project, redirecting the output to |
@@ -99,12 +100,13 @@ the following meanings: | |||
99 | local: a boolean, if True, the path is relative to the local | 100 | local: a boolean, if True, the path is relative to the local |
100 | (sub)manifest. If false, the path is relative to the outermost | 101 | (sub)manifest. If false, the path is relative to the outermost |
101 | manifest. | 102 | manifest. |
102 | project: Project to get status of. | 103 | project_idx: Project index to get status of. |
103 | 104 | ||
104 | Returns: | 105 | Returns: |
105 | The status of the project. | 106 | The status of the project. |
106 | """ | 107 | """ |
107 | buf = io.StringIO() | 108 | buf = io.StringIO() |
109 | project = cls.get_parallel_context()["projects"][project_idx] | ||
108 | ret = project.PrintWorkTreeStatus( | 110 | ret = project.PrintWorkTreeStatus( |
109 | quiet=quiet, output_redir=buf, local=local | 111 | quiet=quiet, output_redir=buf, local=local |
110 | ) | 112 | ) |
@@ -143,15 +145,18 @@ the following meanings: | |||
143 | ret += 1 | 145 | ret += 1 |
144 | return ret | 146 | return ret |
145 | 147 | ||
146 | counter = self.ExecuteInParallel( | 148 | with self.ParallelContext(): |
147 | opt.jobs, | 149 | self.get_parallel_context()["projects"] = all_projects |
148 | functools.partial( | 150 | counter = self.ExecuteInParallel( |
149 | self._StatusHelper, opt.quiet, opt.this_manifest_only | 151 | opt.jobs, |
150 | ), | 152 | functools.partial( |
151 | all_projects, | 153 | self._StatusHelper, opt.quiet, opt.this_manifest_only |
152 | callback=_ProcessResults, | 154 | ), |
153 | ordered=True, | 155 | range(len(all_projects)), |
154 | ) | 156 | callback=_ProcessResults, |
157 | ordered=True, | ||
158 | chunksize=1, | ||
159 | ) | ||
155 | 160 | ||
156 | if not opt.quiet and len(all_projects) == counter: | 161 | if not opt.quiet and len(all_projects) == counter: |
157 | print("nothing to commit (working directory clean)") | 162 | print("nothing to commit (working directory clean)") |