summaryrefslogtreecommitdiffstats
path: root/subcmds/sync.py
diff options
context:
space:
mode:
authorMike Frysinger <vapier@google.com>2019-08-03 02:14:28 -0400
committerMike Frysinger <vapier@google.com>2019-08-04 04:13:55 +0000
commit600f49278ae93ee93c3511562eb81d6690319c75 (patch)
treeab067388454f5bba30dfaa290c6042fb62d36647 /subcmds/sync.py
parent1f2462e0d2dc7002c794936ab81c59c3a9d3cf35 (diff)
downloadgit-repo-600f49278ae93ee93c3511562eb81d6690319c75.tar.gz
project: fix encoding handling with git commands
The GitCommand Wait helper takes care of decoding bytes to strings for us. That means we don't have to decode stdout ourselves which is what our local rev list, ls-remote, and generic get_attr helpers were doing. If we don't use Wait though to capture the output but instead go directly to the subprocess stdout, we do have to handle decoding ourselves. This is what the diff helpers were doing. Bug: https://crbug.com/gerrit/10418 Change-Id: I057ca245af3ff18d6b4a074e3900887f06a5617d Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/233076 Reviewed-by: David Pursehouse <dpursehouse@collab.net> Tested-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'subcmds/sync.py')
0 files changed, 0 insertions, 0 deletions