diff options
author | Raman Tenneti <rtenneti@google.com> | 2021-09-13 17:40:07 -0700 |
---|---|---|
committer | Raman Tenneti <rtenneti@google.com> | 2021-09-14 21:36:12 +0000 |
commit | 6448a4f2af53c241594b5d12eb0d03b18f889eda (patch) | |
tree | 554753373be6dbd595a659907d2016ac203268cd /subcmds/sync.py | |
parent | 1328c35a4d0b47c7e8c00fe351f0e587481e28c2 (diff) | |
download | git-repo-6448a4f2af53c241594b5d12eb0d03b18f889eda.tar.gz |
sync: Log repo sync state events as 'data' events.
git_trace2_event_log.py:
+ Added LogDataConfigEvents method to log 'data' events.
Sync's current_sync_state and previous_sync_state are logged
as 'data' events in the current log.
It logs are key/value in the |config| argument. Each key is
prefixed with |prefix| argument.
The following are sample events that are logged during repo sync.
{"event":"data",
"sid":"repo-20210914T181545Z-P000330c0/repo-20210914T181545Z-P000330c0",
"thread":"MainThread",
"time":"2021-09-14T18:16:19.935846Z",
"key":"previous_sync_state/repo.syncstate.main.synctime",
"value":"2021-09-14T17:27:11.573717Z"}
{"event":"data",
"sid":"repo-20210914T181545Z-P000330c0/repo-20210914T181545Z-P000330c0",
"thread":"MainThread",
"time":"2021-09-14T18:16:19.955546Z",
"key":"current_sync_state/repo.syncstate.main.synctime",
"value":"2021-09-14T18:16:19.935979Z"}
tests/test_git_trace2_event_log.py:
+ Added unit tests
sync.py:
+ Changed logging calls to LogDataConfigEvents.
Tested:
$ ./run_tests
Tested it by running the following command multiple times.
$ repo_dev sync -j 20
repo sync has finished successfully
Verified config data is looged in trace2 event logs.
Bug: [google internal] b/199758376
Change-Id: I75fd830e90c1811ec28510538c99a2632b104e85
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/317823
Reviewed-by: Josh Steadmon <steadmon@google.com>
Reviewed-by: Xin Li <delphij@google.com>
Tested-by: Raman Tenneti <rtenneti@google.com>
Diffstat (limited to 'subcmds/sync.py')
-rw-r--r-- | subcmds/sync.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/subcmds/sync.py b/subcmds/sync.py index 2a0de0a9..c99b06ca 100644 --- a/subcmds/sync.py +++ b/subcmds/sync.py | |||
@@ -1092,13 +1092,13 @@ later is required to fix a server side protocol bug. | |||
1092 | sys.exit(1) | 1092 | sys.exit(1) |
1093 | 1093 | ||
1094 | # Log the previous sync analysis state from the config. | 1094 | # Log the previous sync analysis state from the config. |
1095 | self.git_event_log.LogConfigEvents(mp.config.GetSyncAnalysisStateData(), | 1095 | self.git_event_log.LogDataConfigEvents(mp.config.GetSyncAnalysisStateData(), |
1096 | 'previous_sync_state') | 1096 | 'previous_sync_state') |
1097 | 1097 | ||
1098 | # Update and log with the new sync analysis state. | 1098 | # Update and log with the new sync analysis state. |
1099 | mp.config.UpdateSyncAnalysisState(opt, superproject_logging_data) | 1099 | mp.config.UpdateSyncAnalysisState(opt, superproject_logging_data) |
1100 | self.git_event_log.LogConfigEvents(mp.config.GetSyncAnalysisStateData(), | 1100 | self.git_event_log.LogDataConfigEvents(mp.config.GetSyncAnalysisStateData(), |
1101 | 'current_sync_state') | 1101 | 'current_sync_state') |
1102 | 1102 | ||
1103 | if not opt.quiet: | 1103 | if not opt.quiet: |
1104 | print('repo sync has finished successfully.') | 1104 | print('repo sync has finished successfully.') |