summaryrefslogtreecommitdiffstats
path: root/subcmds/upload.py
diff options
context:
space:
mode:
authorDavid Pursehouse <dpursehouse@collab.net>2020-02-12 15:20:19 +0900
committerDavid Pursehouse <dpursehouse@collab.net>2020-02-12 06:36:40 +0000
commit819827a42ddb364f98c3a1a7eae2536dc54bc4cc (patch)
treefe6bdca5ff7e44d53595a6da76d2b56ea659eee1 /subcmds/upload.py
parentabdf7500612f1d115863ba8f026ddbea1e5a1f28 (diff)
downloadgit-repo-819827a42ddb364f98c3a1a7eae2536dc54bc4cc.tar.gz
Fix blank line issues reported by flake8
- E301 expected 1 blank line - E302 expected 2 blank lines - E303 too many blank lines - E305 expected 2 blank lines after class or function definition - E306 expected 1 blank line before a nested definition Fixed automatically with autopep8: git ls-files | grep py$ | xargs autopep8 --in-place \ --select E301,E302,E303,E305,E306 Manually fix issues in project.py caused by misuse of block comments. Change-Id: Iee840fcaff48aae504ddac9c3e76d2acd484f6a9 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254599 Reviewed-by: Mike Frysinger <vapier@google.com> Tested-by: David Pursehouse <dpursehouse@collab.net>
Diffstat (limited to 'subcmds/upload.py')
-rw-r--r--subcmds/upload.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/subcmds/upload.py b/subcmds/upload.py
index 180496fc..bc373b3e 100644
--- a/subcmds/upload.py
+++ b/subcmds/upload.py
@@ -33,6 +33,7 @@ else:
33 33
34UNUSUAL_COMMIT_THRESHOLD = 5 34UNUSUAL_COMMIT_THRESHOLD = 5
35 35
36
36def _ConfirmManyUploads(multiple_branches=False): 37def _ConfirmManyUploads(multiple_branches=False):
37 if multiple_branches: 38 if multiple_branches:
38 print('ATTENTION: One or more branches has an unusually high number ' 39 print('ATTENTION: One or more branches has an unusually high number '
@@ -44,17 +45,20 @@ def _ConfirmManyUploads(multiple_branches=False):
44 answer = input("If you are sure you intend to do this, type 'yes': ").strip() 45 answer = input("If you are sure you intend to do this, type 'yes': ").strip()
45 return answer == "yes" 46 return answer == "yes"
46 47
48
47def _die(fmt, *args): 49def _die(fmt, *args):
48 msg = fmt % args 50 msg = fmt % args
49 print('error: %s' % msg, file=sys.stderr) 51 print('error: %s' % msg, file=sys.stderr)
50 sys.exit(1) 52 sys.exit(1)
51 53
54
52def _SplitEmails(values): 55def _SplitEmails(values):
53 result = [] 56 result = []
54 for value in values: 57 for value in values:
55 result.extend([s.strip() for s in value.split(',')]) 58 result.extend([s.strip() for s in value.split(',')])
56 return result 59 return result
57 60
61
58class Upload(InteractiveCommand): 62class Upload(InteractiveCommand):
59 common = True 63 common = True
60 helpSummary = "Upload changes for code review" 64 helpSummary = "Upload changes for code review"