summaryrefslogtreecommitdiffstats
path: root/subcmds/upload.py
diff options
context:
space:
mode:
authorConley Owens <cco3@android.com>2013-06-10 14:35:13 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2013-06-10 14:35:13 +0000
commitef668c92c2c87c45df02bf1609a89e4479bbb30c (patch)
tree039f3a11ed6bb9be775a4c242132628a58aa529b /subcmds/upload.py
parent65b162b32fccee038ea331ea47706c4c2ef52692 (diff)
parent691a75936d517f05aaa4a5b0f477d9af5f301b6f (diff)
downloadgit-repo-ef668c92c2c87c45df02bf1609a89e4479bbb30c.tar.gz
Merge "Fix a few issues with dest-branch and multiples"
Diffstat (limited to 'subcmds/upload.py')
-rw-r--r--subcmds/upload.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/subcmds/upload.py b/subcmds/upload.py
index c051f183..fc17670c 100644
--- a/subcmds/upload.py
+++ b/subcmds/upload.py
@@ -232,12 +232,13 @@ Gerrit Code Review: http://code.google.com/p/gerrit/
232 232
233 if b: 233 if b:
234 script.append('#') 234 script.append('#')
235 destination = opt.dest_branch or project.dest_branch or project.revisionExpr
235 script.append('# branch %s (%2d commit%s, %s) to remote branch %s:' % ( 236 script.append('# branch %s (%2d commit%s, %s) to remote branch %s:' % (
236 name, 237 name,
237 len(commit_list), 238 len(commit_list),
238 len(commit_list) != 1 and 's' or '', 239 len(commit_list) != 1 and 's' or '',
239 date, 240 date,
240 project.revisionExpr)) 241 destination))
241 for commit in commit_list: 242 for commit in commit_list:
242 script.append('# %s' % commit) 243 script.append('# %s' % commit)
243 b[name] = branch 244 b[name] = branch
@@ -343,7 +344,8 @@ Gerrit Code Review: http://code.google.com/p/gerrit/
343 key = 'review.%s.uploadtopic' % branch.project.remote.review 344 key = 'review.%s.uploadtopic' % branch.project.remote.review
344 opt.auto_topic = branch.project.config.GetBoolean(key) 345 opt.auto_topic = branch.project.config.GetBoolean(key)
345 346
346 branch.UploadForReview(people, auto_topic=opt.auto_topic, draft=opt.draft, dest_branch=opt.dest_branch) 347 destination = opt.dest_branch or branch.project.dest_branch or branch.project.revisionExpr
348 branch.UploadForReview(people, auto_topic=opt.auto_topic, draft=opt.draft, dest_branch=destination)
347 branch.uploaded = True 349 branch.uploaded = True
348 except UploadError as e: 350 except UploadError as e:
349 branch.error = e 351 branch.error = e