summaryrefslogtreecommitdiffstats
path: root/subcmds
diff options
context:
space:
mode:
authorMike Frysinger <vapier@google.com>2020-02-22 05:30:12 -0500
committerMike Frysinger <vapier@google.com>2020-03-13 18:48:52 +0000
commitbb8ee7f54a4e0bf07d466304d800f13ec41ac21c (patch)
treeaf0dec0603951b94f2cb7a73d273edd486df0fbf /subcmds
parent23d7dafd10e382f42c34618f7c86b3ff1c9d4245 (diff)
downloadgit-repo-bb8ee7f54a4e0bf07d466304d800f13ec41ac21c.tar.gz
manifest_xml: unify bool & int parsing
We've been overly lenient with boolean parsing by ignoring invalid values as "false" even if the user didn't intend that. Turn all unknown values into warnings to avoid breaking existing manifests, and unify the parsing logic in a helper to simplify. We've been stricter about numbers, but still copying & pasting inconsistent code. Add a helper for this too. For out of range sync-j numbers (i.e. less than 1), throw a warning for now, but mark it for future hard failures. Change-Id: I924162b8036e6a5f1e31b6ebb24b6a26ed63712d Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/256457 Reviewed-by: Michael Mortensen <mmortensen@google.com> Tested-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'subcmds')
0 files changed, 0 insertions, 0 deletions