diff options
author | Mike Frysinger <vapier@google.com> | 2022-05-20 06:26:50 -0400 |
---|---|---|
committer | Mike Frysinger <vapier@google.com> | 2022-05-20 11:38:10 +0000 |
commit | 74737da1ab9b5a25c38616d563a973af267277f7 (patch) | |
tree | 23b1758d149942868de03eed6b27c57bbdf9ce51 /tests/test_git_superproject.py | |
parent | 0ddb6776110aaefee3f93cc171d11dcdc12d082b (diff) | |
download | git-repo-74737da1ab9b5a25c38616d563a973af267277f7.tar.gz |
tests: switch to tempfile.TemporaryDirectory
Now that we don't need to support Python 2, we can switch to this
API for better contextmanager logic.
Change-Id: I2d03e391121886547e7808a3b5c3b470c411533f
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/337515
Reviewed-by: LaMont Jones <lamontjones@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'tests/test_git_superproject.py')
-rw-r--r-- | tests/test_git_superproject.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/test_git_superproject.py b/tests/test_git_superproject.py index 1e7b1201..603694d2 100644 --- a/tests/test_git_superproject.py +++ b/tests/test_git_superproject.py | |||
@@ -24,7 +24,6 @@ from unittest import mock | |||
24 | import git_superproject | 24 | import git_superproject |
25 | import git_trace2_event_log | 25 | import git_trace2_event_log |
26 | import manifest_xml | 26 | import manifest_xml |
27 | import platform_utils | ||
28 | from test_manifest_xml import sort_attributes | 27 | from test_manifest_xml import sort_attributes |
29 | 28 | ||
30 | 29 | ||
@@ -38,7 +37,8 @@ class SuperprojectTestCase(unittest.TestCase): | |||
38 | 37 | ||
39 | def setUp(self): | 38 | def setUp(self): |
40 | """Set up superproject every time.""" | 39 | """Set up superproject every time.""" |
41 | self.tempdir = tempfile.mkdtemp(prefix='repo_tests') | 40 | self.tempdirobj = tempfile.TemporaryDirectory(prefix='repo_tests') |
41 | self.tempdir = self.tempdirobj.name | ||
42 | self.repodir = os.path.join(self.tempdir, '.repo') | 42 | self.repodir = os.path.join(self.tempdir, '.repo') |
43 | self.manifest_file = os.path.join( | 43 | self.manifest_file = os.path.join( |
44 | self.repodir, manifest_xml.MANIFEST_FILE_NAME) | 44 | self.repodir, manifest_xml.MANIFEST_FILE_NAME) |
@@ -75,7 +75,7 @@ class SuperprojectTestCase(unittest.TestCase): | |||
75 | 75 | ||
76 | def tearDown(self): | 76 | def tearDown(self): |
77 | """Tear down superproject every time.""" | 77 | """Tear down superproject every time.""" |
78 | platform_utils.rmtree(self.tempdir) | 78 | self.tempdirobj.cleanup() |
79 | 79 | ||
80 | def getXmlManifest(self, data): | 80 | def getXmlManifest(self, data): |
81 | """Helper to initialize a manifest for testing.""" | 81 | """Helper to initialize a manifest for testing.""" |