summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorMike Frysinger <vapier@google.com>2023-08-21 21:26:51 -0400
committerLUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-08-22 18:22:49 +0000
commit06ddc8c50a7e802dbaf8468144c2b5773cda3714 (patch)
tree32cda2abbdf1848ad88e87456f753ef1b838fcbe /tests
parent16109a66b705211efd25f434201d113628aff04c (diff)
downloadgit-repo-06ddc8c50a7e802dbaf8468144c2b5773cda3714.tar.gz
tweak stdlib imports to follow Google style guide
Google Python style guide says to import modules. Clean up all our stdlib imports. Leave the repo ones alone for now as that's a much bigger shave. Change-Id: Ida42fc2ae78b86e6b7a6cbc98f94ca04b295f8cc Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/383714 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Mike Frysinger <vapier@google.com> Tested-by: Mike Frysinger <vapier@google.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/test_repo_logging.py8
-rw-r--r--tests/test_wrapper.py8
2 files changed, 9 insertions, 7 deletions
diff --git a/tests/test_repo_logging.py b/tests/test_repo_logging.py
index ba8a9a9e..5402a90b 100644
--- a/tests/test_repo_logging.py
+++ b/tests/test_repo_logging.py
@@ -14,7 +14,7 @@
14 14
15"""Unit test for repo_logging module.""" 15"""Unit test for repo_logging module."""
16import unittest 16import unittest
17from unittest.mock import MagicMock 17from unittest import mock
18 18
19from repo_logging import RepoLogger 19from repo_logging import RepoLogger
20 20
@@ -30,7 +30,7 @@ class TestRepoLogger(unittest.TestCase):
30 nonlocal result 30 nonlocal result
31 result = log.getMessage() 31 result = log.getMessage()
32 32
33 mock_out = MagicMock() 33 mock_out = mock.MagicMock()
34 mock_out.level = 0 34 mock_out.level = 0
35 mock_out.handle = mock_handler 35 mock_out.handle = mock_handler
36 logger.addHandler(mock_out) 36 logger.addHandler(mock_out)
@@ -49,7 +49,7 @@ class TestRepoLogger(unittest.TestCase):
49 nonlocal result 49 nonlocal result
50 result = log.getMessage() 50 result = log.getMessage()
51 51
52 mock_out = MagicMock() 52 mock_out = mock.MagicMock()
53 mock_out.level = 0 53 mock_out.level = 0
54 mock_out.handle = mock_handler 54 mock_out.handle = mock_handler
55 logger.addHandler(mock_out) 55 logger.addHandler(mock_out)
@@ -88,7 +88,7 @@ class TestRepoLogger(unittest.TestCase):
88 nonlocal result 88 nonlocal result
89 result.append(log.getMessage()) 89 result.append(log.getMessage())
90 90
91 mock_out = MagicMock() 91 mock_out = mock.MagicMock()
92 mock_out.level = 0 92 mock_out.level = 0
93 mock_out.handle = mock_handler 93 mock_out.handle = mock_handler
94 logger.addHandler(mock_out) 94 logger.addHandler(mock_out)
diff --git a/tests/test_wrapper.py b/tests/test_wrapper.py
index 4e8263b2..ef4dce10 100644
--- a/tests/test_wrapper.py
+++ b/tests/test_wrapper.py
@@ -14,7 +14,7 @@
14 14
15"""Unittests for the wrapper.py module.""" 15"""Unittests for the wrapper.py module."""
16 16
17from io import StringIO 17import io
18import os 18import os
19import re 19import re
20import sys 20import sys
@@ -47,8 +47,10 @@ class RepoWrapperUnitTest(RepoWrapperTestCase):
47 def test_version(self): 47 def test_version(self):
48 """Make sure _Version works.""" 48 """Make sure _Version works."""
49 with self.assertRaises(SystemExit) as e: 49 with self.assertRaises(SystemExit) as e:
50 with mock.patch("sys.stdout", new_callable=StringIO) as stdout: 50 with mock.patch("sys.stdout", new_callable=io.StringIO) as stdout:
51 with mock.patch("sys.stderr", new_callable=StringIO) as stderr: 51 with mock.patch(
52 "sys.stderr", new_callable=io.StringIO
53 ) as stderr:
52 self.wrapper._Version() 54 self.wrapper._Version()
53 self.assertEqual(0, e.exception.code) 55 self.assertEqual(0, e.exception.code)
54 self.assertEqual("", stderr.getvalue()) 56 self.assertEqual("", stderr.getvalue())