diff options
Diffstat (limited to 'SUBMITTING_PATCHES')
-rw-r--r-- | SUBMITTING_PATCHES | 30 |
1 files changed, 29 insertions, 1 deletions
diff --git a/SUBMITTING_PATCHES b/SUBMITTING_PATCHES index 50e2cf77..8656ee7d 100644 --- a/SUBMITTING_PATCHES +++ b/SUBMITTING_PATCHES | |||
@@ -4,7 +4,9 @@ Short Version: | |||
4 | - Provide a meaningful commit message. | 4 | - Provide a meaningful commit message. |
5 | - Check for coding errors with pylint | 5 | - Check for coding errors with pylint |
6 | - Make sure all code is under the Apache License, 2.0. | 6 | - Make sure all code is under the Apache License, 2.0. |
7 | - Publish your changes for review: | 7 | - Publish your changes for review. |
8 | - Make corrections if requested. | ||
9 | - Verify your changes on gerrit so they can be submitted. | ||
8 | 10 | ||
9 | git push https://gerrit-review.googlesource.com/git-repo HEAD:refs/for/master | 11 | git push https://gerrit-review.googlesource.com/git-repo HEAD:refs/for/master |
10 | 12 | ||
@@ -75,6 +77,17 @@ Ensure you have obtained an HTTP password to authenticate: | |||
75 | 77 | ||
76 | https://gerrit-review.googlesource.com/new-password | 78 | https://gerrit-review.googlesource.com/new-password |
77 | 79 | ||
80 | Ensure that you have the local commit hook installed to automatically | ||
81 | add a ChangeId to your commits: | ||
82 | |||
83 | curl -Lo `git rev-parse --git-dir`/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg | ||
84 | chmod +x `git rev-parse --git-dir`/hooks/commit-msg | ||
85 | |||
86 | If you have already committed your changes you will need to amend the commit | ||
87 | to get the ChangeId added. | ||
88 | |||
89 | git commit --amend | ||
90 | |||
78 | Push your patches over HTTPS to the review server, possibly through | 91 | Push your patches over HTTPS to the review server, possibly through |
79 | a remembered remote to make this easier in the future: | 92 | a remembered remote to make this easier in the future: |
80 | 93 | ||
@@ -85,3 +98,18 @@ a remembered remote to make this easier in the future: | |||
85 | 98 | ||
86 | You will be automatically emailed a copy of your commits, and any | 99 | You will be automatically emailed a copy of your commits, and any |
87 | comments made by the project maintainers. | 100 | comments made by the project maintainers. |
101 | |||
102 | |||
103 | (5) Make changes if requested | ||
104 | |||
105 | The project maintainer who reviews your changes might request changes to your | ||
106 | commit. If you make the requested changes you will need to amend your commit | ||
107 | and push it to the review server again. | ||
108 | |||
109 | |||
110 | (6) Verify your changes on gerrit | ||
111 | |||
112 | After you receive a Code-Review+2 from the maintainer, select the Verified | ||
113 | button on the gerrit page for the change. This verifies that you have tested | ||
114 | your changes and notifies the maintainer that they are ready to be submitted. | ||
115 | The maintainer will then submit your changes to the repository. | ||