diff options
author | David Pursehouse <dpursehouse@collab.net> | 2020-02-12 15:40:47 +0900 |
---|---|---|
committer | David Pursehouse <dpursehouse@collab.net> | 2020-02-12 06:49:25 +0000 |
commit | 145e35b805957487601514481df23b8fb723be38 (patch) | |
tree | d8d932f32782e485d9b95fb4d104d1427bce5981 /subcmds/sync.py | |
parent | 819827a42ddb364f98c3a1a7eae2536dc54bc4cc (diff) | |
download | git-repo-145e35b805957487601514481df23b8fb723be38.tar.gz |
Fix usage of bare 'except'
flake8 reports:
E722 do not use bare 'except'
Replace them with 'except Exception' per [1] which says:
Bare except will catch exceptions you almost certainly don't want
to catch, including KeyboardInterrupt (the user hitting Ctrl+C) and
Python-raised errors like SystemExit
If you don't have a specific exception you're expecting, at least
except Exception, which is the base type for all "Regular" exceptions.
[1] https://stackoverflow.com/a/54948581
Change-Id: Ic555ea9482645899f5b04040ddb6b24eadbf9062
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254606
Reviewed-by: Mike Frysinger <vapier@google.com>
Tested-by: David Pursehouse <dpursehouse@collab.net>
Diffstat (limited to 'subcmds/sync.py')
-rw-r--r-- | subcmds/sync.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/subcmds/sync.py b/subcmds/sync.py index c433ce6f..cc058af6 100644 --- a/subcmds/sync.py +++ b/subcmds/sync.py | |||
@@ -603,7 +603,7 @@ later is required to fix a server side protocol bug. | |||
603 | bare_git.gc('--auto', config=config) | 603 | bare_git.gc('--auto', config=config) |
604 | except GitError: | 604 | except GitError: |
605 | err_event.set() | 605 | err_event.set() |
606 | except: | 606 | except Exception: |
607 | err_event.set() | 607 | err_event.set() |
608 | raise | 608 | raise |
609 | finally: | 609 | finally: |